Jetpack pricing: fix alternative texts in modals

[monsieur-z]

Changes proposed in this Pull Request

This PR adds an accessible name to the close button of the language selector, in the footer of the Jetpack pricing page, and the products lightbox. This way, visitors using a screen reader get proper context when the button gets focus (see video below).

Implementation notes

Name is added via the aria-label HTML attribute.

Testing instructions

• Spin up the pricing page, by running this branch locally, or by using the live link below
• Visit the pricing page, and open the language selector located in the footer

• Using a screen reader, notice that the close button has an accessible name (see video below). Alternatively, check in the inspector that the HTML element has a aria-label attribute.

• Do the same with the products lightbox (click More on X).

Screenshots

close-button.mov

Voice Over gives information about the close button when it is given focus.

lightbox.mov

Same here. Besides, Voice Over ignores icons completely.

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • 0-as-1203150321101696

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~125 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
jetpack-cloud-pricing       +276 B  (+0.0%)     +125 B  (+0.1%)
plans                       +135 B  (+0.0%)      +60 B  (+0.0%)
jetpack-connect             +135 B  (+0.0%)      +60 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-46170

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-46170&env=jetpack

[jkguidaven]

Nice catch @monsieur-z! tested and working as expected. code looks good to me👍

[jkguidaven]

Though not required for this PR. The close button in the lightbox also needs to have the aria-label. It might also need some styling when it is active.

[monsieur-z]

Making sure icons are not read by screen readers here, since they are purely decorative.

[monsieur-z]

Thanks @jkguidaven! I missed that modal. I've updated the code and instructions accordingly.

[jkguidaven]

Thanks for fixing all accessibility issues @monsieur-z .. the code looks good to me and it tested good. 💯 👍

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7582258

Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.