Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Portal: add react-query mutation to handle assigning multiple licenses flow #69183

Merged
merged 1 commit into from Nov 1, 2022

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Oct 18, 2022

Proposed Changes

This PR adds a new react-query mutation to handle assigning multiple licenses flow.

Testing Instructions

No testing is needed on this PR. The test instructions will be provided in the upcoming PR where this will be used. You could just review the code changes here.

Pre-merge Checklist

Related to 1203126240279377-as-1203156900348731

@yashwin yashwin added Jetpack Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Oct 18, 2022
@yashwin yashwin requested a review from a team October 18, 2022 11:17
@yashwin yashwin self-assigned this Oct 18, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 18, 2022
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin force-pushed the add/react-query-mutation-for-multiple-licenses branch from e418417 to d5f9453 Compare October 18, 2022 11:35
@yashwin yashwin force-pushed the add/react-query-mutation-for-multiple-licenses branch from d5f9453 to 868ac74 Compare October 21, 2022 05:56
@yashwin yashwin force-pushed the add/react-query-mutation-for-multiple-licenses branch from 868ac74 to 79aa398 Compare October 21, 2022 05:58
@rcanepa
Copy link
Contributor

rcanepa commented Oct 27, 2022

I see a significant overlap between useLicenseIssuing and useIssueMultipleLicenses, which makes me wonder if there is an opportunity to abstract the commonalities.

Is useIssueMultipleLicenses expected to work for a single license too? If so, could we replace useLicenseIssuing with useIssueMultipleLicenses everywhere?

Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new function looks good to me. However, I haven't tried it, but I know we will once we connect it to the new product catalog page.

Therefore, I approve it since this won't be visible to current users and won't introduce any regression.

@vitozev vitozev merged commit b8bc65f into trunk Nov 1, 2022
@vitozev vitozev deleted the add/react-query-mutation-for-multiple-licenses branch November 1, 2022 13:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants