Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad: Add domain ssl processing notification #69317

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

jeyip
Copy link
Contributor

@jeyip jeyip commented Oct 21, 2022

Proposed Changes

  • Show a notification message underneath the domains preview noting that it is in the process of being set up

Screenshots

Screen Shot 2022-10-21 at 12 20 06 AM

Testing Instructions

  • Check out this PR
  • Create new site through tailored flow https://wordpress.com/hp-2022-tailored-flows/
  • Make sure to switch out wordpress.com with calypso.localhost:3000
  • Create a custom domain for the site
  • Choose, at minimum, a personal plan ( so that we can make a custom domain the primary domain )
  • Complete steps until at the Launchpad screen
  • Verify that there is a domain ssl processing notification until ssl is active on the custom domain

Pre-merge Checklist

Related to #68967

@jeyip jeyip added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. labels Oct 21, 2022
@jeyip jeyip self-assigned this Oct 21, 2022
@jeyip jeyip marked this pull request as ready for review October 21, 2022 07:16
@github-actions
Copy link

github-actions bot commented Oct 21, 2022

@matticbot
Copy link
Contributor

matticbot commented Oct 21, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~75 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +138 B  (+0.0%)      +75 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@edanzer
Copy link
Contributor

edanzer commented Oct 24, 2022

UPDATE: Issue above with free .wordpress.com domains showing the message has been resolved.

  • Set up new site with custom domain and confirmed new message appears initially.
  • Set up free site (*.wordpress.com domain) to confirm the message does NOT show. From what I'm seeing, the new message still shows. I don't think that's expected.
    • Just quickly checking the code to see what's happening, the sslStatus variable seems to be null for my new wordpress.com domain.

@jeyip jeyip force-pushed the add/launchpad-domain-related-notifications branch from 5c53559 to db7137c Compare October 24, 2022 17:40
@jeyip jeyip requested a review from a team as a code owner October 24, 2022 18:07
@jeyip
Copy link
Contributor Author

jeyip commented Oct 24, 2022

Set up free site (*.wordpress.com domain) to confirm the message does NOT show. From what I'm seeing, the new message still shows. I don't think that's expected.

Thanks for the patience with this @edanzer. I pushed a fix with tests to cover the null case

@agrullon95
Copy link
Contributor

agrullon95 commented Oct 24, 2022

LGTM.

  • Tested with existing free domain & paid domain : SSL notification message does not display in sidebar.
  • Tested with new paid domain on personal plan: SSL notification message displays in sidebar while custom domain SSL status is pending.

@agrullon95 agrullon95 self-requested a review October 24, 2022 19:18
Copy link
Contributor

@bstoynov bstoynov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and this tests well.

Testing

✔️ Notification is showing when using a pain domain with a personal plan while domain is pending
✔️ Notification is not showing when using a free domain

@Addison-Stavlo
Copy link
Contributor

Addison-Stavlo commented Oct 25, 2022

Regarding the notification - are we able to add the circle green check icon and corresponding text offset as shown in the similar design here ?

@kirahsapong
Copy link
Contributor

Changes look good except for the green checkmark @Addison-Stavlo noted above.

Testing

[x] Notification shows with new custom domain
[x] Notification does not show with existing custom domain
[x] Notification does not show with any [site].wordpress.com domain
[ ] Design matches mock-up

@jeyip
Copy link
Contributor Author

jeyip commented Oct 25, 2022

Regarding the notification - are we able to add the circle green check icon and corresponding text offset as shown in the similar design #68967 (comment) ?

I wasn't certain if we wanted to add the icon as well, but I'm happy to do so in a follow-up

@edanzer
Copy link
Contributor

edanzer commented Oct 25, 2022

Changes look good. Retested this after recent changes, and tests as expected. The issue I noted above with free .wordpress.com domains showing the new message is resolved. I also ran the unit tests, and they are all passing.

@jeyip jeyip removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 26, 2022
@jeyip jeyip merged commit f0ab353 into trunk Oct 26, 2022
@jeyip jeyip deleted the add/launchpad-domain-related-notifications branch October 26, 2022 19:52
@a8ci18n
Copy link

a8ci18n commented Oct 26, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7596273

Thank you @jeyip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 3, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants