-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBE : WebsiteContent : Several Copy changes #69336
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~115 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
9d0083b
to
1edd10a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the left sidebar and modal look good.
I noticed an issue when testing the feedback section. The entire form switches to the right when the feedback section is expanded. This does not happen in prod right now.
Kapture.2022-10-27.at.16.10.10.mp4
@aneeshd16 I added a minimum width to the section to fix this. |
57a960d
to
2618697
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7598983 Thank you @jdc91 for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Updates to left sidebar text on website content form
Modal Changes
Submit Content Section change
Testing Instructions
/start/do-it-for-me
Pre-merge Checklist
Fixes Automattic/martech#1144
Fixes Automattic/martech#1145
Fixes Automattic/martech#1223