Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBE : WebsiteContent : Several Copy changes #69336

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

ddc22
Copy link
Contributor

@ddc22 ddc22 commented Oct 21, 2022

Proposed Changes

  • Copy changes

Updates to left sidebar text on website content form

image

Modal Changes

image

Submit Content Section change

image

Testing Instructions

  • Go to /start/do-it-for-me
  • Go through the flow and complete purchas
  • Make sure above changes are visible in the website-content page

Pre-merge Checklist

Fixes Automattic/martech#1144
Fixes Automattic/martech#1145
Fixes Automattic/martech#1223

@ddc22 ddc22 marked this pull request as draft October 21, 2022 11:59
@github-actions
Copy link

github-actions bot commented Oct 21, 2022

@matticbot
Copy link
Contributor

matticbot commented Oct 21, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~115 bytes added 📈 [gzipped])

name                                                   parsed_size           gzip_size
async-load-signup-steps-website-content                     +305 B  (+0.2%)     +115 B  (+0.2%)
async-load-signup-steps-website-content-section-types       +127 B  (+0.2%)      +42 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ddc22 ddc22 added the DIFM Express Built By Express Onboarding Pipeline related tasks label Oct 23, 2022
@ddc22 ddc22 force-pushed the update/copy-changes-to-website-content branch from 9d0083b to 1edd10a Compare October 24, 2022 09:56
@ddc22 ddc22 self-assigned this Oct 24, 2022
@ddc22 ddc22 changed the title BBE : WebsiteContent : Several Copy changes and addition of per section description BBE : WebsiteContent : Several Copy changes Oct 26, 2022
@ddc22 ddc22 marked this pull request as ready for review October 27, 2022 08:24
Copy link
Contributor

@aneeshd16 aneeshd16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the left sidebar and modal look good.

I noticed an issue when testing the feedback section. The entire form switches to the right when the feedback section is expanded. This does not happen in prod right now.

Kapture.2022-10-27.at.16.10.10.mp4

@ddc22
Copy link
Contributor Author

ddc22 commented Oct 27, 2022

@aneeshd16 I added a minimum width to the section to fix this.

@ddc22 ddc22 force-pushed the update/copy-changes-to-website-content branch from 57a960d to 2618697 Compare October 27, 2022 15:27
@ddc22 ddc22 added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 28, 2022
@ddc22 ddc22 requested a review from aneeshd16 October 28, 2022 05:06
Copy link
Contributor

@aneeshd16 aneeshd16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The modal width looks a bit large to me. What do you think about reducing the width?
image

@ddc22
Copy link
Contributor Author

ddc22 commented Oct 28, 2022

Modal, fixed with a max width
Screenshot 2022-10-28 at 11 03 44 AM

@ddc22 ddc22 merged commit 6718887 into trunk Oct 28, 2022
@ddc22 ddc22 deleted the update/copy-changes-to-website-content branch October 28, 2022 07:38
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 28, 2022
@a8ci18n
Copy link

a8ci18n commented Oct 28, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7598983

Thank you @jdc91 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 3, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DIFM Express Built By Express Onboarding Pipeline related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants