New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launchpad: Add checkmark icon to domain processing notification #69498
Conversation
I can go either way with unit tests for this feature. We are already checking for notification text here, so checking for the icon as well seems a little excessive to me, but I'm happy to verify it as well if folks prefer. |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~40 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Tests:
|
I think it's fine to not test for this icon since you already tested for the actual SSL processing message which is more important. |
Code looks good. Tests as expected, with green check now showing just before domain setup notification. For tests, obviously fine to add them, but I'd agree not needed here. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7598736 Thank you @jeyip for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Testing Instructions
Pre-merge Checklist
Related to #68967