Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad: Add checkmark icon to domain processing notification #69498

Merged
merged 1 commit into from Oct 27, 2022

Conversation

jeyip
Copy link
Contributor

@jeyip jeyip commented Oct 26, 2022

Proposed Changes

  • Adds checkmark icon to domain processing notification

Screen Shot 2022-10-26 at 4 52 54 PM

Testing Instructions

  • Check out this PR
  • Create new site through tailored flow https://wordpress.com/hp-2022-tailored-flows/
  • Make sure to switch out wordpress.com with calypso.localhost:3000
  • Create a custom domain for the site
  • Choose, at minimum, a personal plan ( so that we can make a custom domain the primary domain )
  • Complete steps until at the Launchpad screen
  • Verify that the domain ssl processing notification has a green checkmark icon

Pre-merge Checklist

Related to #68967

@jeyip jeyip added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. labels Oct 26, 2022
@jeyip jeyip self-assigned this Oct 26, 2022
@jeyip jeyip marked this pull request as ready for review October 26, 2022 23:55
@jeyip
Copy link
Contributor Author

jeyip commented Oct 26, 2022

I can go either way with unit tests for this feature. We are already checking for notification text here, so checking for the icon as well seems a little excessive to me, but I'm happy to verify it as well if folks prefer.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~40 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +160 B  (+0.0%)      +40 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@agrullon95
Copy link
Contributor

agrullon95 commented Oct 27, 2022

Tests:

  • Verify that the domain ssl processing notification has a green checkmark icon

@agrullon95
Copy link
Contributor

I can go either way with unit tests for this feature. We are already checking for notification text here, so checking for the icon as well seems a little excessive to me, but I'm happy to verify it as well if folks prefer.

I think it's fine to not test for this icon since you already tested for the actual SSL processing message which is more important.

@edanzer
Copy link
Contributor

edanzer commented Oct 27, 2022

Code looks good. Tests as expected, with green check now showing just before domain setup notification. For tests, obviously fine to add them, but I'd agree not needed here.

@jeyip jeyip merged commit b761d9d into trunk Oct 27, 2022
@jeyip jeyip deleted the add/checkmark-icon-to-launchpad-notification branch October 27, 2022 18:48
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 27, 2022
@a8ci18n
Copy link

a8ci18n commented Oct 27, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7598736

Thank you @jeyip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 3, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants