Sites as landing page: Display success notice after accepting /sites landing page opt-in

[p-jackson]

Proposed Changes

PR inspired by this feedback. Not part of the original project brief so see what @zaguiini thinks before merging.

Shows a success <GlobalNotice> after accepting the SALP opt-in banner

Screen.Recording.2022-11-30.at.5.28.31.PM.mov

I did a little searching, and there doesn't seem to be any consistency around whether global notices should end with a full stop or exclamation point or end with the word "successful". I went with "Default page updated".

I don't think we should show anything after rejecting the banner. IMO it doesn't make sense because, as far as the user is concerned, they haven't changed any preference. They're sticking with the status quo.

Testing Instructions

• Delete the entire sites-landing-page preference object using the dev menu in the bottom right
• Go to /sites
• Accept banner. After saving is complete the global notice appears. The calypso_sites_dashboard_landing_page_banner_accept_click banner fires just like it used to.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-50390

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-50390&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~53 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
sites-dashboard       +137 B  (+0.0%)      +53 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[vykes-mac]

This is good to me, notice adds feedback to the user in the context.

[zaguiini]

@p-jackson tests are failing, could you please merge this once you start working? Thanks!

EDIT: rebasing fixed the problem. p6fDka-Ls-p2

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7648226

Hi @p-jackson, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Default page updated.

Thank you in advance!

[a8ci18n]

Translation for this Pull Request has now been finished.