Refactor Pricing Plan block to use variants #70629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This Pull Request refactors the previously multiple times registered Pricing Plan block to use the variations API which greatly simplifies the code and prevents some issues we have found regarding inconsistent titles and description in the editor settings UI after plans configurations are changed.
Testing Instructions
yarn dev --sync
inapps/happy-blocks
to sync code to your sandboxwp-content/themes/a8c/supportforums/editor/gutenberg-wpcom.php
and add to the functionsupportforums_gutenberg_setup_frontend
beforereturn $settings;
line:$settings['iso']['blocks']['allowBlocks'][] = 'happy-blocks/*...
leaving just the new one./
and search for "Upgrade" block.Pre-merge Checklist
Related to #