Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Site for Preview: Improve notice message text #70769

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

danielbachhuber
Copy link
Contributor

@danielbachhuber danielbachhuber commented Dec 5, 2022

Proposed Changes

Improves the notice message text to make it more consistent with other messages:

CleanShot 2022-12-05 at 06 39 28@2x

CleanShot 2022-12-05 at 06 39 20@2x

Testing Instructions

  1. Create a new Business site.
  2. Navigate to 'General Settings'.
  3. Click 'Create a preview link' toggle and see success notice displayed as 'Preview link created.'
  4. Click 'Create a preview link' toggle and see success notice displayed as 'Preview link removed.'

@danielbachhuber danielbachhuber added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. Share Site for Preview i1 labels Dec 5, 2022
@danielbachhuber danielbachhuber self-assigned this Dec 5, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

@matticbot
Copy link
Contributor

matticbot commented Dec 5, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
settings        -27 B  (-0.0%)       -6 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well.

@danielbachhuber danielbachhuber merged commit b92f0fe into trunk Dec 5, 2022
@danielbachhuber danielbachhuber deleted the improve/site-preview-link-messages branch December 5, 2022 14:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2022
@a8ci18n
Copy link

a8ci18n commented Dec 5, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7659364

Thank you @danielbachhuber for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 15, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. Share Site for Preview i1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants