Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting Configuration: Update copy and icon in revamped #71898

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Jan 10, 2023

Proposed Changes

Implementing copy changes discussed here pet6gk-1j-p2

  • Updating copy
  • Change icon for database access

CleanShot 2023-01-12 at 11 48 50@2x

Change depends on #71750

Testing Instructions

  • Go to experiment page 20995-explat-experiment
  • Add the treatment bookmarklet to your bookmark bar
  • Click bookmarklet and add your user to the treatment cohort (tutorial video p1673249013170409/1673241333.083479-slack-C04H4NY6STW)
  • calypso.localhost:3000/hosting-config in a site with no business plan
  • You should see the updated copy

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #71832

@p-jackson p-jackson self-assigned this Jan 10, 2023
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

@p-jackson p-jackson added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2023
@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2023

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Base automatically changed from test/hosting-upsell-revamp to trunk January 11, 2023 22:25
@p-jackson p-jackson force-pushed the update/hosting-upsell-revamp-copy branch from 4f1ca66 to 1e941bb Compare January 11, 2023 22:46
@p-jackson p-jackson force-pushed the update/hosting-upsell-revamp-copy branch from 1e941bb to 50c00a2 Compare January 11, 2023 23:01
@p-jackson p-jackson merged commit 451c8b7 into trunk Jan 12, 2023
@p-jackson p-jackson deleted the update/hosting-upsell-revamp-copy branch January 12, 2023 00:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 12, 2023
@a8ci18n
Copy link

a8ci18n commented Jan 12, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7727673

Thank you @p-jackson for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jan 20, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants