-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domain upsell copy for translation #72296
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Co-authored-by: Gabriel Demichelis <gabrieldemichelis@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave a little comment but after that it's all good to me 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only have one question, after that, it's ready for me!
I added print screens to the PR description @DustyReagan, so once you ask for |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7758175 Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7758175 Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators. |
* Add domain upsell copy for translation * Update client/my-sites/customer-home/translations/domain-upsell.js Co-authored-by: Gabriel Demichelis <gabrieldemichelis@gmail.com> * Split 1 translation into 2 for line break Co-authored-by: Gabriel Demichelis <gabrieldemichelis@gmail.com>
Translation for this Pull Request has now been finished. |
Proposed Changes
This PR adds preemptive translations for strings found in our design docs. When the project is in production and fully translated to the mag-16, this file and its containing folder can be removed.
Testing Instructions
This code is never executed.
Please proof read the copy and make sure it matches what is in the Figma, linked in the comment here: pebzTe-xR-p2#comment-969
Is anything missing? Do the
translation
functions look ok?Prints to help on translation
Pre-merge Checklist
Related to #71498