Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain upsell copy for translation #72296

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Add domain upsell copy for translation #72296

merged 3 commits into from
Jan 19, 2023

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Jan 18, 2023 •
edited by paulopmt1
Loading

Proposed Changes

This PR adds preemptive translations for strings found in our design docs. When the project is in production and fully translated to the mag-16, this file and its containing folder can be removed.

Testing Instructions

This code is never executed.

Please proof read the copy and make sure it matches what is in the Figma, linked in the comment here: pebzTe-xR-p2#comment-969

Is anything missing? Do the translation functions look ok?

Prints to help on translation

image

image

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #71498

@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-54538
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-54538&env=jetpack

@DustyReagan DustyReagan self-assigned this Jan 18, 2023
@DustyReagan DustyReagan requested a review from a team January 18, 2023 20:55
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 18, 2023
@DustyReagan DustyReagan marked this pull request as ready for review January 18, 2023 20:56
@DustyReagan DustyReagan linked an issue Jan 18, 2023 that may be closed by this pull request
My home domain upsell: send copy for translation #71498
Closed
1 task
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan @lupus2k
Update client/my-sites/customer-home/translations/domain-upsell.js
c9f5f7e 
Co-authored-by: Gabriel Demichelis <gabrieldemichelis@gmail.com>
lupus2k
lupus2k approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@lupus2k lupus2k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave a little comment but after that it's all good to me 🚀

paulopmt1
paulopmt1 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only have one question, after that, it's ready for me!

client/my-sites/customer-home/translations/domain-upsell.js Outdated Show resolved Hide resolved
@paulopmt1
Copy link
Contributor

I added print screens to the PR description @DustyReagan, so once you ask for string freeze they will be sent to translation folk as well.

@paulopmt1 paulopmt1 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 19, 2023
@a8ci18n
Copy link

a8ci18n commented Jan 19, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7758175

Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators.

@DustyReagan DustyReagan merged commit cb5ecff into trunk Jan 19, 2023
@DustyReagan DustyReagan deleted the add/domain-upsell-translations branch January 19, 2023 17:50
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 19, 2023
@a8ci18n
Copy link

a8ci18n commented Jan 19, 2023 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7758175

Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators.

autumnfjeld pushed a commit that referenced this pull request Jan 23, 2023
@DustyReagan @lupus2k
Add domain upsell copy for translation (#72296)
e088104 
* Add domain upsell copy for translation

* Update client/my-sites/customer-home/translations/domain-upsell.js

Co-authored-by: Gabriel Demichelis <gabrieldemichelis@gmail.com>

* Split 1 translation into 2 for line break

Co-authored-by: Gabriel Demichelis <gabrieldemichelis@gmail.com>
@a8ci18n
Copy link

a8ci18n commented Jan 25, 2023

Translation for this Pull Request has now been finished.

@DustyReagan DustyReagan mentioned this pull request Jan 30, 2023
Merged
7 tasks
@paulopmt1 paulopmt1 mentioned this pull request Feb 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lupus2k lupus2k lupus2k approved these changes

@paulopmt1 paulopmt1 paulopmt1 approved these changes

Assignees

@DustyReagan DustyReagan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

My home domain upsell: send copy for translation
5 participants
@DustyReagan @matticbot @paulopmt1 @a8ci18n @lupus2k