Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans 2023 : Removed feature group innovative features and other updates #72757

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Plans 2023 : Removed feature group innovative features and other updates #72757

merged 4 commits into from
Jan 31, 2023

Conversation

ddc22
Copy link
Contributor

@ddc22 ddc22 commented Jan 30, 2023 •
edited
Loading

Proposed Changes

  • Removed group innovative technologies, and reorganised features and updated changes done to the list
  • Updates to group titles as shown in the design file
    image

Testing Instructions

  • Go to /start/plans?flags=onboarding/2023-pricing-grid
  • The groups and features should be displayed correctly in the correct order and grouping

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Fixes Automattic/martech#1433

@github-actions
Copy link

github-actions bot commented Jan 30, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-55650
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-55650&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2023 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~70 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper       -182 B  (-0.0%)      -70 B  (-0.0%)
entry-main          -182 B  (-0.0%)      -70 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Async-loaded Components (~70 bytes removed 📉 [gzipped])

name                                           parsed_size           gzip_size
async-load-calypso-blocks-inline-help-popover       -182 B  (-0.0%)      -70 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ddc22 ddc22 changed the title Removed group innovative technologies, and update other changes to features Plans 2023 : Removed feature group innovative features and other updates Jan 30, 2023
@ddc22 ddc22 self-assigned this Jan 30, 2023
@ddc22 ddc22 added the 2023 Pricing Page ⚡ Changes for pricing page optimisation 2023 label Jan 30, 2023
@ddc22 ddc22 marked this pull request as ready for review January 30, 2023 06:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2023
@ddc22
Copy link
Contributor Author

ddc22 commented Jan 30, 2023

@claudiucelfilip can you please have another look at this PR?

aneeshd16
aneeshd16 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@aneeshd16 aneeshd16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, one difference that I found between the design and implementation:

Design
image

Implementation
image

Please feel free to ignore if this has been discussed already!

packages/calypso-products/src/feature-group-plan-map.ts Outdated
@@ -70,20 +69,22 @@ import { FeatureGroupMap } from './types';
export const featureGroups: Partial< FeatureGroupMap > = {
[ FEATURE_GROUP_GENERAL_FEATURES ]: {
slug: FEATURE_GROUP_GENERAL_FEATURES,
Copy link
Contributor

@aneeshd16 aneeshd16 Jan 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: What do you think about renaming the slug to FEATURE_GROUP_ESSENTIAL_FEATURES? Might reduce confusion in the future. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good call I will do this.

@ddc22
Change variable name
13bbfdd 
Minor text change
@ddc22 ddc22 requested a review from a team as a code owner January 31, 2023 06:57
claudiucelfilip
claudiucelfilip approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@claudiucelfilip claudiucelfilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Features now match. Thank you!

LGTM

@ddc22 ddc22 merged commit d40138a into trunk Jan 31, 2023
@ddc22 ddc22 deleted the add/update-feature-groups branch January 31, 2023 10:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2023
@a8ci18n
Copy link

a8ci18n commented Jan 31, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7784520

Thank you @jdc91 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Feb 10, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiucelfilip claudiucelfilip claudiucelfilip approved these changes

@aneeshd16 aneeshd16 aneeshd16 approved these changes

Assignees

@ddc22 ddc22

Labels
2023 Pricing Page ⚡ Changes for pricing page optimisation 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ddc22 @matticbot @a8ci18n @claudiucelfilip @aneeshd16