Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text updates on the pricing page #73361

Merged
merged 4 commits into from Feb 17, 2023
Merged

Text updates on the pricing page #73361

merged 4 commits into from Feb 17, 2023

Conversation

augurlu
Copy link
Contributor

@augurlu augurlu commented Feb 15, 2023

Text updates on the pricing page to better promote the individual plugins.

Related to #

Proposed Changes

  • Changing titles of the sections and Security blurb on the pricing page
  • You can find more info on pbNhbs-5o6-p2

Changes:

  • Bundle section – title:
    • Most popular bundles -> Bundle and save
  • Bundle section – blurbs:
    • Removing blurbs and mentioning standalone plugins
  • Individual plugin section – title:
    • All products -> Products with individual plugin

Testing Instructions

  • Patch the changes
  • Check if there is a typo
  • If everything looks good, we can deploy the changes.

Before
Screen Shot 2023-02-15 at 14 55 11

After
Screen Shot 2023-02-15 at 14 55 43

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Text updates on the pricing page to better promote the individual plugins.
@augurlu augurlu requested a review from a team as a code owner February 15, 2023 07:56
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 15, 2023
@matticbot
Copy link
Contributor

matticbot commented Feb 15, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~96 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +242 B  (+0.0%)      +96 B  (+0.0%)
entry-main          +242 B  (+0.0%)      +97 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~14 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
plans                        +15 B  (+0.0%)      +14 B  (+0.0%)
jetpack-connect              +15 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-pricing        +15 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~95 bytes added 📈 [gzipped])

name                                           parsed_size           gzip_size
async-load-calypso-blocks-inline-help-popover       +242 B  (+0.0%)      +95 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Adjusting space
@matticbot
Copy link
Contributor

This PR modifies the release build for happy-blocks

To test your changes on WordPress.com, run install-plugin.sh happy-blocks update/pricing-page on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/pricing-page on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

Revising the comment section
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, doesn't break the design of anything, I just noticed an unused component in one of the translation strings

packages/calypso-products/src/plans-list.tsx Outdated Show resolved Hide resolved
packages/calypso-products/src/plans-list.tsx Outdated Show resolved Hide resolved
Removing unused components and fixing comment string.
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeyGuyDylan CodeyGuyDylan merged commit bd1f49d into trunk Feb 17, 2023
@CodeyGuyDylan CodeyGuyDylan deleted the update/pricing-page branch February 17, 2023 17:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 17, 2023
@a8ci18n
Copy link

a8ci18n commented Feb 17, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7820134

Thank you @augurlu for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Feb 23, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants