Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use build_meta.json instead of build_meta.txt. #73747

Closed
wants to merge 6 commits into from

Conversation

worldomonation
Copy link
Contributor

Related to #73557.

Proposed Changes

This PR migrates all builds to produce a build_meta.json instead of the build_meta.txt, completing the missing task in #73557.

Testing Instructions

Calypso App builds should produce a build_meta.json.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@worldomonation worldomonation self-assigned this Feb 24, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

plugins: [ ...webpackConfig.plugins, new ReadableJsAssetsWebpackPlugin() ],
plugins: [
...webpackConfig.plugins,
BuildMetaPlugin( { outputPath } ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we base this on webpackConfig.output instead of having a separate variable? (same for happy-blocks)

@noahtallen noahtallen force-pushed the try-parallel-app-processing branch 2 times, most recently from f12bbfe to 4503eab Compare March 15, 2023 00:01
Base automatically changed from try-parallel-app-processing to trunk March 15, 2023 21:40
@worldomonation worldomonation deleted the update/use-build-meta-for-apps branch October 24, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done🎊
Development

Successfully merging this pull request may close these issues.

None yet

3 participants