Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Fix unescaped BusinessPlanUpgradeUpsellTreatment discount string #73925

Merged
merged 1 commit into from
Mar 10, 2023
Merged

i18n: Fix unescaped BusinessPlanUpgradeUpsellTreatment discount string #73925

merged 1 commit into from
Mar 10, 2023

Conversation

yuliyan
Copy link
Member

@yuliyan yuliyan commented Mar 1, 2023

Related to 577-gh-Automattic/i18n-issues

Proposed Changes

  • Escape the % character in Upgrade now and we'll give you {{b}}%(discount)d%% off your....
  • Split into two separate strings for month and year terms to allow for more accurate translations for languages with gendered nouns.

CleanShot 2023-03-01 at 11 01 51

Testing Instructions

  • Make sure you are assigned to the treatment group for calypso_postpurchase_upsell_countdown_timer experiment.
  • Create a new site with Premium plan or upgrade an existing site to Premium.
  • Finish the checkout process (using credits).
  • Confirm the % character is being rendered as expected on the Business plan upgrade screen.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@yuliyan yuliyan requested a review from a team March 1, 2023 09:09
@yuliyan yuliyan requested a review from a team as a code owner March 1, 2023 09:09
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-983d4be4cf1110364c7a76aa590fba002dc1cb29
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-983d4be4cf1110364c7a76aa590fba002dc1cb29&env=jetpack

@yuliyan yuliyan added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Mar 1, 2023
@a8ci18n
Copy link

a8ci18n commented Mar 1, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7836325

Thank you @yuliyan for including a screenshot in the description! This is really helpful for our translators.

jornp
jornp approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@jornp jornp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM! 🚀

@a8ci18n
Copy link

a8ci18n commented Mar 9, 2023

Translation for this Pull Request has now been finished.

@yuliyan yuliyan merged commit 698606a into trunk Mar 10, 2023
@yuliyan yuliyan deleted the fix/plan-upgrade-upsell-discount-stirng-unescaped-character branch March 10, 2023 11:37
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jornp jornp jornp approved these changes

Assignees
No one assigned
Labels
i18n [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuliyan @a8ci18n @jornp @matticbot