-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: Use string interpolation for tax names in VAT form #74538
Checkout: Use string interpolation for tax names in VAT form #74538
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~544 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~493 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
8da9743
to
37ebb78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well. Let's String Freeze
it.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7871432 Thank you @sirbrillig for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
The checkout billing info/contact info form sometimes collects VAT information depending on the country chosen. Because the name of VAT changes based on country, it would be better to use a localized term. In #73686 we modified the labels for the VAT form use use the more generic term "Business Tax", but this is still a little unclear.
In this PR we switch each of these labels to replace "Business Tax" with the selected country's term for VAT (eg: "GST", "CT", etc.).
NOTE: this adds a good number of new strings. Make sure to translate these before merging!
NOTE 2: this does not alter the labels of other pages that interact with VAT, like
/me/purchases/vat-details
, because on those pages it's not as easy to tell what country we should use to determine the label. Updating those (if possible) will be the subject of a different PR.Before:
After:
Testing Instructions