Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woo Express Performance: Plans page copy changes #74989

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

markbiek
Copy link
Contributor

@markbiek markbiek commented Mar 27, 2023

Fixes #74899

Proposed Changes

  • Update the plan name in the plans-list (Woo Express Performance to Performance)
  • Change the plans sub header text for Performance and trial plan sites

Original subheader copy

See and compare the features available on each WordPress.com plan.

Woo Express subheader copy

Discover what's available in your Woo Express plan.

Testing Instructions

  • Apply this patch or use the calypso.live link.

Non-Woo Express site

  • Create any non-Woo Express site. A free site is the easiest.
  • Go to /plans/:siteSlug.
  • You should see the original plans subheader copy.

image

Woo Express Trial site

  • Create a Woo Express trial site by going to /setup/wooexpress.
  • Go to /plans/:siteSlug.
  • You should see the new subheader copy.
  • The name of the plan should also just be "Performance".

image

Woo Express Performance site

  • Upgrade the trial site created previously (or go to an existing Performance plan site).
  • Go to /plans/:siteSlug.
  • You should see the new subheader copy.
  • The name of the plan should also just be "Performance".

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Mar 27, 2023

@matticbot
Copy link
Contributor

matticbot commented Mar 27, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        -12 B  (-0.0%)       +3 B  (+0.0%)
entry-main           -12 B  (-0.0%)       +3 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~58 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
plans       +107 B  (+0.0%)      +58 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~0 bytes added 📈 [gzipped])

name                                           parsed_size           gzip_size
async-load-calypso-blocks-inline-help-popover        -12 B  (-0.0%)       +0 B

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@markbiek markbiek force-pushed the 74899-update/wx-plans-page-copy-updates branch from f5a1938 to f95baf8 Compare March 27, 2023 20:22
@matticbot
Copy link
Contributor

This PR modifies the release build for happy-blocks

To test your changes on WordPress.com, run install-plugin.sh happy-blocks 74899-update/wx-plans-page-copy-updates on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit 74899-update/wx-plans-page-copy-updates on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@markbiek markbiek force-pushed the 74899-update/wx-plans-page-copy-updates branch from 1c4784e to afc4201 Compare March 28, 2023 11:23
@markbiek markbiek changed the title WIP: 74899 update/wx plans page copy updates Woo Express Performance: Plans page copy changes Mar 28, 2023
@markbiek markbiek requested a review from a team March 28, 2023 11:37
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2023
@markbiek markbiek marked this pull request as ready for review March 28, 2023 13:46
@markbiek markbiek requested a review from a team as a code owner March 28, 2023 13:46
Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@markbiek markbiek merged commit 2c1934f into trunk Mar 28, 2023
@markbiek markbiek deleted the 74899-update/wx-plans-page-copy-updates branch March 28, 2023 17:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2023
@a8ci18n
Copy link

a8ci18n commented Mar 28, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7892982

Thank you @markbiek for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 7, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Woo Express Copy Updates: Plans page
4 participants