-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains: Adapt domain registrant verification page to be used with DSAPI reseller domains #75595
Domains: Adapt domain registrant verification page to be used with DSAPI reseller domains #75595
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~294 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think we should also hide the button in getExpiredState
as I'm pretty sure we won't be able to resend the verification email. But other than that I think it's working great!
Thanks for the review @hambai, and that's a good point! I've updated that page to hide the button and changed the message accordingly. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7931307 Thank you @leonardost for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
This PR updates the domain registrant verification landing page (
/domain-services/registrant-verification/
) to be used with DSAPI reseller domains.A new
reseller=reseller-name
query parameter can be added to the URL. When that's added, references to WPCOM links and support pages are removed. If the reseller istumblr
, the Tumblr logo is shown in place of the WordPress logo.Screenshots
Testing Instructions
/domains/{domain}/verify-email
endpoint to return different success and error responses/domain-services/registrant-verification?domain=example.com&email=example@example.com&token=1234&reseller=tumblr_ote
Pre-merge Checklist