Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Adapt domain registrant verification page to be used with DSAPI reseller domains #75595

Conversation

leonardost
Copy link
Contributor

@leonardost leonardost commented Apr 12, 2023

Proposed Changes

This PR updates the domain registrant verification landing page (/domain-services/registrant-verification/) to be used with DSAPI reseller domains.

A new reseller=reseller-name query parameter can be added to the URL. When that's added, references to WPCOM links and support pages are removed. If the reseller is tumblr, the Tumblr logo is shown in place of the WordPress logo.

Screenshots

  • Success

Screenshot 2023-04-11 at 20 46 10

  • Email already verified

Screenshot 2023-04-11 at 21 02 58

  • Expired email

Screenshot 2023-04-14 at 14 56 47

  • Mismatched email address

Screenshot 2023-04-11 at 20 56 18

  • Error message

Screenshot 2023-04-11 at 20 45 31

Testing Instructions

  • Open the live Calypso link or build this branch locally
  • Hack your backend's /domains/{domain}/verify-email endpoint to return different success and error responses
  • Access the registrant verification landing page with some example query parameters, e.g. /domain-services/registrant-verification?domain=example.com&email=example@example.com&token=1234&reseller=tumblr_ote
  • Ensure the different backend responses' show pages as shown in the screenshots above

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@leonardost leonardost requested a review from a team as a code owner April 12, 2023 00:07
@leonardost leonardost self-assigned this Apr 12, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 12, 2023
@matticbot
Copy link
Contributor

matticbot commented Apr 12, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~294 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-domains-landing       +617 B  (+0.1%)     +294 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@leonardost leonardost added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Apr 12, 2023
Copy link
Contributor

@hambai hambai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we should also hide the button in getExpiredState as I'm pretty sure we won't be able to resend the verification email. But other than that I think it's working great!

@leonardost
Copy link
Contributor Author

Thanks for the review @hambai, and that's a good point! I've updated that page to hide the button and changed the message accordingly.

@leonardost leonardost merged commit a7bcba0 into trunk Apr 17, 2023
4 checks passed
@leonardost leonardost deleted the update/adapt-registrant-verification-page-to-be-used-with-dsapi-domains branch April 17, 2023 22:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 17, 2023
@a8ci18n
Copy link

a8ci18n commented Apr 18, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7931307

Thank you @leonardost for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 27, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants