Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable widget v2 and turn on for wpcalypso so we can test #77193

Merged
merged 1 commit into from
May 22, 2023

Conversation

benzhu56
Copy link
Contributor

@benzhu56 benzhu56 commented May 22, 2023

Proposed Changes

  • Show widget flow redesign for wpcalypso track.

Testing Instructions

See widget PR dsp for test instructions.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@benzhu56 benzhu56 self-assigned this May 22, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 22, 2023
@github-actions
Copy link

github-actions bot commented May 22, 2023

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~314 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
promote-post         +307 B  (+0.1%)     +237 B  (+0.1%)
stats                +122 B  (+0.0%)      +38 B  (+0.0%)
posts-custom         +122 B  (+0.0%)      +57 B  (+0.0%)
posts                +122 B  (+0.0%)      +57 B  (+0.0%)
pages                +122 B  (+0.0%)      +57 B  (+0.0%)
site-purchases        +32 B  (+0.0%)      +18 B  (+0.0%)
home                  +32 B  (+0.0%)      +21 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~18 bytes added 📈 [gzipped])

name                                 parsed_size           gzip_size
async-load-calypso-my-sites-sidebar        +32 B  (+0.0%)      +18 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@kthai15 kthai15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested feature flag and integration, everything appears in order 👍

Copy link
Contributor

@kthai15 kthai15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested feature flag and integration, everything appears in order 👍

@benzhu56 benzhu56 merged commit b022572 into trunk May 22, 2023
26 of 27 checks passed
@benzhu56 benzhu56 deleted the benz56/wp-blaze-turn-on-v2-for-testing branch May 22, 2023 23:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 22, 2023
@benzhu56 benzhu56 mentioned this pull request May 22, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants