-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BulkDomainTransfer: improve default error message #78750
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~43 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~43 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested every case I can think of and all works!
...ative-flow/internals/steps-repository/bulk-domain-transfer-domains/use-validation-message.ts
Outdated
Show resolved
Hide resolved
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8070997 Hi @heavyweight, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
This PR fallbacks on getAvailabilityNotice to check for possible message before displaying the general error
Proposed Changes
getAvailabilityNotice
Testing Instructions
Pre-merge Checklist