Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkDomainTransfer: improve default error message #78750

Merged
merged 8 commits into from
Jun 29, 2023

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Jun 28, 2023

This PR fallbacks on getAvailabilityNotice to check for possible message before displaying the general error

Proposed Changes

  • Improve default error message by using getAvailabilityNotice

Testing Instructions

  • Checkout this branch and build or use the PR link
  • Test the new flow using domain names you have auth codes with and for other possible cases.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Jun 28, 2023

@matticbot
Copy link
Contributor

matticbot commented Jun 28, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~43 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
videopress-flow               +163 B  (+0.0%)      +43 B  (+0.0%)
update-design-flow            +163 B  (+0.0%)      +43 B  (+0.0%)
tailored-ecommerce-flow       +163 B  (+0.0%)      +43 B  (+0.0%)
sensei-flow                   +163 B  (+0.1%)      +43 B  (+0.1%)
podcasts-flow                 +163 B  (+0.1%)      +43 B  (+0.1%)
link-in-bio-tld-flow          +163 B  (+0.0%)      +43 B  (+0.0%)
domains                       +163 B  (+0.0%)      +43 B  (+0.0%)
copy-site-flow                +163 B  (+0.0%)      +43 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~43 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       +163 B  (+0.0%)      +43 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@heavyweight heavyweight marked this pull request as ready for review June 28, 2023 18:00
@alshakero alshakero self-requested a review June 28, 2023 20:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 28, 2023
@alshakero alshakero requested a review from a team as a code owner June 29, 2023 12:59
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested every case I can think of and all works!

@heavyweight heavyweight merged commit f7adc32 into trunk Jun 29, 2023
18 checks passed
@heavyweight heavyweight deleted the bulk-domain-transfer-status branch June 29, 2023 17:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 29, 2023
@a8ci18n
Copy link

a8ci18n commented Jun 29, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8070997

Hi @heavyweight, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Sorry, WordPress.com does not support the %(tld)s TLD.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Jul 7, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants