Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites: add domains page CTA #78768

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

mpkelly
Copy link
Contributor

@mpkelly mpkelly commented Jun 29, 2023

Closes https://github.com/Automattic/dotcom-forge/issues/2846

Mockup:

image

Proposed Changes

  • Add a link button /domains/manage
Rvq9s7.mp4

Existing Tracks event:

image

Testing Instructions

  • Try it out at /sites
  • Check mobile and desktop match the Figma design
  • Is the existing Tracks event enough?

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@mpkelly mpkelly added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. Domains page emphasis i1 labels Jun 29, 2023
@mpkelly mpkelly self-assigned this Jun 29, 2023
@mpkelly mpkelly requested review from jeyip and a team June 29, 2023 08:51
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 29, 2023
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit add/manage-all-domains-button-to-sites on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~243 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
sites-dashboard               +238 B  (+0.1%)      +73 B  (+0.1%)
import-hosted-site-flow       +238 B  (+0.0%)      +77 B  (+0.0%)
import-flow                   +238 B  (+0.0%)      +92 B  (+0.0%)
site-setup-flow                +23 B  (+0.0%)      +12 B  (+0.0%)
plugins                        +23 B  (+0.0%)      +12 B  (+0.0%)
media                          +23 B  (+0.0%)      +12 B  (+0.0%)
activity                       +23 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~12 bytes added 📈 [gzipped])

name                                               parsed_size           gzip_size
async-load-design-playground                             +23 B  (+0.0%)      +12 B  (+0.0%)
async-load-design-blocks                                 +23 B  (+0.0%)      +12 B  (+0.0%)
async-load-design                                        +23 B  (+0.0%)      +12 B  (+0.0%)
async-load-calypso-post-editor-media-modal               +23 B  (+0.0%)      +12 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal        +23 B  (+0.0%)      +12 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@zaguiini
Copy link
Contributor

Working fine 👍

Is the existing Tracks event enough?

Yes, we can track link clicks.

@zaguiini zaguiini merged commit 0f12a97 into trunk Jun 29, 2023
24 of 25 checks passed
@zaguiini zaguiini deleted the add/manage-all-domains-button-to-sites branch June 29, 2023 12:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 29, 2023
@a8ci18n
Copy link

a8ci18n commented Jun 29, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8070394

Thank you @mpkelly for including a screenshot in the description! This is really helpful for our translators.

@saygunnyc
Copy link

Thank you for quickly implementing this.
Can we ensure the secondary CTA uses the same styling as this other secondary CTA – Yes, make it My Home?

Screenshot 2023-06-29 at 5 06 10 PM

@a8ci18n
Copy link

a8ci18n commented Jul 7, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domains page emphasis i1 Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants