Sidebar: refresh Manage all domains button #78803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaguiini
added
[Status] Needs Review
zaguiini
changed the title
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
zaguiini
changed the title
mpkelly
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Looking good.
I found a bug when when testing a11y and have opened https://github.com/Automattic/dotcom-forge/issues/2888
github-actions
bot
removed
the
[Status] Needs Review
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8071459 Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators. |
|
Translation for this Pull Request has now been finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Automattic/dotcom-forge/issues/2868.
Proposed Changes
This PR changes the label and icon of the multi-site context CTA for the domains page in the sidebar:
I also updated the slug from
upgradestodomains. As far as I could tell, this particular slug is only used to identify the click on Tracks: https://github.com/Automattic/wp-calypso/blob/trunk/client/components/site-selector/index.jsx#L367. Let me know if there are bigger implications and the need to revert this change before merging.Testing Instructions