Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Remove single bar shortcuts #84083

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

grzegorz-cp
Copy link
Contributor

@grzegorz-cp grzegorz-cp commented Nov 10, 2023

Related to #84082

Proposed Changes

  • remove Today and Yesterday shortcuts
  • add Last 90 Days shortcut showing the period as weeks

Testing Instructions

  • go to live branch
  • open the date picker and verify that the shortcuts don't list today and yesterday
  • verify that the new option for last 90 days is available
  • verify that the shortcuts work
Before After
SCR-20231110-lxzp SCR-20231110-lxvr

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@grzegorz-cp grzegorz-cp added the Stats Everything related to our analytics product at /stats/ label Nov 10, 2023
@grzegorz-cp grzegorz-cp requested a review from a team November 10, 2023 02:16
@grzegorz-cp grzegorz-cp self-assigned this Nov 10, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 10, 2023
Copy link

github-actions bot commented Nov 10, 2023

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit
  • happy-blocks
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/stats-84082-remove-today on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~8 bytes removed 📉 [gzipped])

name   parsed_size           gzip_size
stats        -51 B  (-0.0%)       -8 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~14 bytes removed 📉 [gzipped])

name                                       parsed_size           gzip_size
async-load-store-app-store-stats-listview        -51 B  (-0.0%)       -6 B  (-0.0%)
async-load-store-app-store-stats                 -51 B  (-0.0%)       -8 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@grzegorz-cp grzegorz-cp merged commit 298378a into trunk Nov 10, 2023
16 of 18 checks passed
@grzegorz-cp grzegorz-cp deleted the fix/stats-84082-remove-today branch November 10, 2023 03:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 10, 2023
@a8ci18n
Copy link

a8ci18n commented Nov 10, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/9664120

Thank you @grzegorz-cp for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 16, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants