Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domains: Add Glue Records management UI #84261

Merged
merged 27 commits into from
Dec 7, 2023
Merged

Domains: Add Glue Records management UI #84261

merged 27 commits into from
Dec 7, 2023

Conversation

rafaelgallani
Copy link
Contributor

@rafaelgallani rafaelgallani commented Nov 16, 2023 •
edited by leonardost
Loading

Proposed Changes

This PR creates a card to manage glue records in the domain management page. Glue records can be added for domains that are registered with us through Key-Systems. It's currently behind a feature flag (domains/glue-records).

Screenshots

  • The card is initially closed

Markup on 2023-12-06 at 20:47:39

  • Open card

Markup on 2023-12-06 at 20:47:15

  • Open card with glue record added
Screenshot 2023-12-07 at 10 29 20

Testing Instructions

  • Open the live Calypso link or build this branch locally
  • Go to the domain management page for a domain that's registered with us via Key-Systems
  • Append ?flags=domains/glue-records to your URL
  • Ensure the card is shown correctly
  • Try adding and removing glue records and ensure it works correctly

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@rafaelgallani rafaelgallani self-assigned this Nov 16, 2023
@rafaelgallani rafaelgallani requested a review from a team as a code owner November 16, 2023 17:01
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 16, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-90211
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-90211&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Nov 16, 2023 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/glue-records-management on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Nov 16, 2023 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1294 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains      +5283 B  (+0.3%)    +1294 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

gius80
gius80 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@gius80 gius80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and works as expected.

It would be nice to show a validation error too other than the red outline (maybe in a separate PR, before removing the feature flag).

Screenshot 2023-12-07 alle 10 07 27

@leonardost
Copy link
Contributor

@gius80 thanks for the review! I actually thought of adding validation messages but didn't do it 😬 but now I've added them 👍

gius80
gius80 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@gius80 gius80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the update!

@leonardost leonardost merged commit 7ddfb9d into trunk Dec 7, 2023
12 checks passed
@leonardost leonardost deleted the add/glue-records-management branch December 7, 2023 17:29
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] In Progress labels Dec 7, 2023
@a8ci18n
Copy link

a8ci18n commented Dec 7, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/10052296

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @rafaelgallani for including a screenshot in the description! This is really helpful for our translators.

@leonardost leonardost mentioned this pull request Dec 7, 2023
Merged
7 tasks
cpapazoglou pushed a commit that referenced this pull request Dec 11, 2023
@rafaelgallani @leonardost @cpapazoglou
Domains: Add Glue Records management UI (#84261)
7f8de8a 
* Add initial structure

* Fix styles

* Improve styles

* Add feature flags

* Replace `Remove` link with button

* Improve loading state

* Improve placeholder labels

* Update field labels

* Add limit of glue records

* Improve react-query cached data

* Include placeholder style

* Force lowercase nameservers

* Render `Add Glue Records` action only when necessary

* Fix cancel button behavior

* Lazy query

* Improve data caching

* Only show glue records card for domains registered with us

* Fix comments

* Validate record and IP address fields before saving glue record

* Rename method `handleAddGlueRecord` to `showGlueRecordForm`

* Fix comment

* Add missing dependency for `useEffect`

* Simplify condition

* Only show glue records card for domains registered through Key-Systems

* Add error validation message to glue record fields

* Remove references to domain forwarding and simplify CSS

* Fetch data when expanding card to prevent stale data from being shown

---------

Co-authored-by: Leonardo Sameshima Taba <leonardo.taba@automattic.com>
@a8ci18n
Copy link

a8ci18n commented Dec 11, 2023

Translation for this Pull Request has now been finished.

@leonardost leonardost mentioned this pull request Dec 11, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gius80 gius80 gius80 approved these changes

Assignees

@rafaelgallani rafaelgallani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rafaelgallani @matticbot @leonardost @a8ci18n @gius80