Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Add feature of Traffic spike forgiveness to the feature list #85831

Merged
merged 8 commits into from
Dec 28, 2023

Conversation

dognose24
Copy link
Contributor

Related to #85813

Proposed Changes

  • Add the feature of traffic spike forgiveness to the Stats Commercial purchase page with an information popover.
  • Refactor existing popover styling of the purchase page for reuse.
  • Patch the info icon for the fee per unit information.

Testing Instructions

  • Apply the latest Diff D129634-code and sandbox public-api.wordpress.com and Store Sandbox.
  • Spin this change up on local Calypso.
  • Create a new JN site and connect it to Jetpack.
  • Navigate to the Commercial purchase page for the new JN site: /stats/purchase/{site-slug}?productType=commercial.
  • Ensure the traffic spike forgiveness feature is displayed with an information popover on the feature list.
  • Ensure the info icon and popover for the fee per unit information work as previously.
截圖 2023-12-28 下午11 06 07
  • Purchase the 2M tier and return to the purchase page.
  • Ensure the info icon and popover for the fee per unit information are not displayed.
截圖 2023-12-28 下午11 22 42

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@dognose24 dognose24 added the Stats Everything related to our analytics product at /stats/ label Dec 28, 2023
@dognose24 dognose24 requested a review from a team December 28, 2023 15:27
@dognose24 dognose24 self-assigned this Dec 28, 2023
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 28, 2023
Copy link

github-actions bot commented Dec 28, 2023

@matticbot
Copy link
Contributor

matticbot commented Dec 28, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~339 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
add-ons      +1410 B  (+0.4%)     +339 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~308 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-signup-steps-add-ons                       +1410 B  (+0.7%)     +344 B  (+0.5%)
async-load-calypso-my-sites-stats-stats-purchase       +684 B  (+1.0%)     +187 B  (+0.9%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats_add_feature_spike_forgiveness on your sandbox.

@kangzj kangzj merged commit 900bae3 into trunk Dec 28, 2023
11 checks passed
@kangzj kangzj deleted the update/stats_add_feature_spike_forgiveness branch December 28, 2023 22:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 28, 2023
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the PR but didn't approve and now doing it 😄 ✅

@a8ci18n
Copy link

a8ci18n commented Dec 28, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/10555504

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @dognose24 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jan 3, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants