Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Calypso user management #86602

Closed
wants to merge 3 commits into from
Closed

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Jan 18, 2024

Needs D135326-code to have the email of the invited user

Temporary, not so beautiful, design.

image

It can be shipped behind a flag only on development, or wait for design.

Testing

  1. Apply the diff to your sandbox.
  2. Sandbox public api.
  3. Visit [live link]/people/team/[site slug]
  4. Invite a user that is not connected to a wp.com user (should be gray)

@escapemanuele escapemanuele self-assigned this Jan 18, 2024
Copy link

github-actions bot commented Jan 18, 2024

@escapemanuele escapemanuele added this to In progress in Vertex Team Board via automation Jan 18, 2024
@matticbot
Copy link
Contributor

matticbot commented Jan 18, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~234 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
people       +909 B  (+0.2%)     +234 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@escapemanuele escapemanuele changed the title Better Site Migration: Calypso user management Improve Calypso user management Jan 19, 2024
@escapemanuele escapemanuele removed this from In progress in Vertex Team Board Jan 19, 2024
@escapemanuele escapemanuele added Jetpack SSO [Status] Needs Design Add this to PRs that need input from Design labels Jan 23, 2024
@github-actions github-actions bot added the [Status] Design Input Requested Label automatically added to PRs where design feedback is requested label Jan 23, 2024
@crisbusquets
Copy link
Contributor

FYI I'm checking this now, @escapemanuele

@crisbusquets
Copy link
Contributor

Hi!

Here's a design proposal: DASWajWXHUUjF4pu1yo4fI-fi-74_3489

The goal is to reinforce why the site owner needs to invite them "again" to the site, and also add a link to learn more about the Secure Sign On.

Let me know what do you think 🚀

Team member list

invite-gh

When adding a team member

I designed two proposals for this. I recommend the option with the tab (A) because it's less confusing: it doesn't combine different Invites and status.

invite-tabs-gh

@escapemanuele
Copy link
Contributor Author

Done here: #88369

@github-actions github-actions bot removed [Status] Needs Design Add this to PRs that need input from Design [Status] Design Input Requested Label automatically added to PRs where design feedback is requested labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants