Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update My Home subtitle text #87786

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Update My Home subtitle text #87786

merged 1 commit into from
Feb 22, 2024

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented Feb 22, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/5750

Before:

Your hub for posting, editing, and growing your site.

Image

After

Your hub for next steps, support center, and quick links.

Image

Copy link

github-actions bot commented Feb 22, 2024

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/my-home-subtitle on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Feb 22, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~34 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +234 B  (+0.0%)      +22 B  (+0.0%)
entry-main                  +234 B  (+0.0%)      +21 B  (+0.0%)
entry-subscriptions         +126 B  (+0.0%)       +9 B  (+0.0%)
entry-login                 +126 B  (+0.0%)       +9 B  (+0.0%)
entry-domains-landing       +126 B  (+0.0%)       +9 B  (+0.0%)
entry-browsehappy           +126 B  (+0.1%)       +9 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2086 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
home                                  +200 B  (+0.0%)     +500 B  (+0.1%)
scan                                  +181 B  (+0.0%)       -2 B  (-0.0%)
site-purchases                        -103 B  (-0.0%)      -29 B  (-0.0%)
purchases                             -103 B  (-0.0%)      -29 B  (-0.0%)
jetpack-search                        +103 B  (+0.0%)      +30 B  (+0.0%)
backup                                 -92 B  (-0.0%)       -2 B  (-0.0%)
email                                  -90 B  (-0.0%)     -153 B  (-0.1%)
domains                                -90 B  (-0.0%)       +2 B  (+0.0%)
themes                                 -13 B  (-0.0%)      -33 B  (-0.0%)
theme                                  -13 B  (-0.0%)      -33 B  (-0.0%)
plugins                                -13 B  (-0.0%)       +6 B  (+0.0%)
marketplace                            -13 B  (-0.0%)      -32 B  (-0.0%)
jetpack-cloud-plugin-management        -13 B  (-0.0%)      -21 B  (-0.0%)
hosting                                -13 B  (-0.0%)      -30 B  (-0.0%)
checkout                               -13 B  (-0.0%)       -4 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@eoigal eoigal added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 22, 2024
@eoigal eoigal merged commit ad13677 into trunk Feb 22, 2024
11 checks passed
@eoigal eoigal deleted the update/my-home-subtitle branch February 22, 2024 21:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 22, 2024
@a8ci18n
Copy link

a8ci18n commented Feb 22, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/11406251

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @eoigal for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Feb 26, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants