-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO: Add invite user button option #88369
Changes from all commits
a5b59ff
0e5d298
5dc0b2a
90cd024
6c33370
74fb30b
65b999d
77f7906
5721ce0
fd83cc4
9f2e827
0ea9519
4045525
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,14 +96,13 @@ export class PeopleInviteDetails extends PureComponent { | |
requesting, | ||
invite, | ||
translate, | ||
deleteSuccess, | ||
requestingResend, | ||
resendSuccess, | ||
inviteWasDeleted, | ||
deletingInvite, | ||
} = this.props; | ||
|
||
if ( ! site || ! site.ID || deleteSuccess ) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @agrullon95 same here |
||
if ( ! site || ! site.ID ) { | ||
return this.renderPlaceholder(); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,11 +150,6 @@ describe( 'PeopleInviteDetails', () => { | |
expect( mockGoBack ).toHaveBeenCalledTimes( 1 ); | ||
expect( mockGoBack ).toHaveBeenCalledWith( '/people/invites/' + siteObject.slug ); | ||
|
||
// Verify that a placeholder is rendered while waiting for `page.back` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we are refreshing the list again after revoking or inviting, we don't need this placeholder anymore. |
||
// to take effect. | ||
const loadingUsersEl2 = screen.queryByText( 'Loading Users' ); | ||
expect( loadingUsersEl2 ).toBeInTheDocument(); | ||
|
||
// Change another prop and verify that `page.back` isn't called again. | ||
rerender( <PeopleInviteDetails { ...props } invite={ { ...acceptedInviteObject } } /> ); | ||
expect( mockGoBack ).toHaveBeenCalledTimes( 1 ); | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @agrullon95 To keep the pending list up to date, I had to remove this logic added by you in #86927. Could you please help me to test and make sure it is still working well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall why I added that there, but I didn't notice any issues with invitations/revokes when testing.