-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Migration: Update site identification step copy #89548
Conversation
HOC technique is deprecated in favor or react hooks
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~60 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@gabrielcaires To clarify, it still works in this manner?
Assuming that's correct, I really like the new copy. I think it makes things more clear for people. |
@@ -50,6 +53,8 @@ export const Analyzer: FC< Props > = ( { onComplete, onSkip } ) => { | |||
hasError={ hasError } | |||
skipInitialChecking | |||
onDontHaveSiteAddressClick={ onSkip } | |||
placeholder={ translate( 'yoursite.com or tumblr.com/username' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to confirm we own/have the rights to use any example domains we suggest in the copy -- yoursite.com
goes to a UK hosting company we probably don't want to give traffic to and tumblr.com/username
has some questionable content 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a list of example domains we can use here: PCYsg-eI0-p2. We already use some of them in https://wordpress.com/move/
...anding/stepper/declarative-flow/internals/steps-repository/site-migration-identify/index.tsx
Outdated
Show resolved
Hide resolved
...anding/stepper/declarative-flow/internals/steps-repository/site-migration-identify/index.tsx
Outdated
Show resolved
Hide resolved
I think "Enter your site address or platform address" is confusing, and as you mentioned @sixhours, people could mistakenly enter the URL of the platform instead of the address of their sites, so I would just say "Enter your site address". @michaelpick could you or Francisco have a look at the copy of the page, please? |
Hi @javierarce! Here's our doc! We left a few versions. |
Thanks, @alvezfrancese! I've mixed and matched two lines from the alternatives you gave us to make the wording more simple: @sixhours I've also removed Link to Figma: https://www.figma.com/file/5yhaC6umexdQLlLpCrCyEe/Migrations?type=design&node-id=2863-13707&mode=design&t=neorvIWYNSg804vk-4 |
Looking good, @javierarce! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Waiting for the translations to be deployed, it will probably happen today. |
Related to #89543
Proposed Changes
Update the copy based on the suggestionsTesting Instructions
/setup/site-migration/site-migration-identify?siteSlug=[YOUR_SITE].wordpress.com
Pre-merge Checklist