Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Update site identification step copy #89548

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Apr 15, 2024

Related to #89543

Proposed Changes

image

Testing Instructions

  • Just access /setup/site-migration/site-migration-identify?siteSlug=[YOUR_SITE].wordpress.com

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires added [Feature] Site Migration Features related to site migrations to WPcom DO NOT MERGE labels Apr 15, 2024
@gabrielcaires gabrielcaires requested a review from a team April 15, 2024 18:49
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 15, 2024
@gabrielcaires gabrielcaires marked this pull request as ready for review April 15, 2024 18:50
@gabrielcaires gabrielcaires requested a review from a team as a code owner April 15, 2024 18:50
@matticbot
Copy link
Contributor

matticbot commented Apr 15, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~60 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
import-hosted-site-flow        +53 B  (+0.0%)      +12 B  (+0.0%)
import-flow                    +53 B  (+0.0%)      +18 B  (+0.0%)
import                         +53 B  (+0.0%)      +30 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@markbiek
Copy link
Contributor

@gabrielcaires To clarify, it still works in this manner?

  • If the user enters a WordPress url, they stay in the site-migration flow.
  • If the user enters a non-WordPress url, they go into the Import flow.

Assuming that's correct, I really like the new copy. I think it makes things more clear for people.

@@ -50,6 +53,8 @@ export const Analyzer: FC< Props > = ( { onComplete, onSkip } ) => {
hasError={ hasError }
skipInitialChecking
onDontHaveSiteAddressClick={ onSkip }
placeholder={ translate( 'yoursite.com or tumblr.com/username' ) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to confirm we own/have the rights to use any example domains we suggest in the copy -- yoursite.com goes to a UK hosting company we probably don't want to give traffic to and tumblr.com/username has some questionable content 😅

Copy link

@javierarce javierarce Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a list of example domains we can use here: PCYsg-eI0-p2. We already use some of them in https://wordpress.com/move/

@javierarce javierarce self-assigned this Apr 16, 2024
@javierarce
Copy link

I think "Enter your site address or platform address" is confusing, and as you mentioned @sixhours, people could mistakenly enter the URL of the platform instead of the address of their sites, so I would just say "Enter your site address".

@michaelpick could you or Francisco have a look at the copy of the page, please?

@gabrielcaires gabrielcaires self-assigned this Apr 16, 2024
@alvezfrancese
Copy link

Hi @javierarce! Here's our doc! We left a few versions.

@javierarce
Copy link

javierarce commented Apr 18, 2024

Thanks, @alvezfrancese!

I've mixed and matched two lines from the alternatives you gave us to make the wording more simple:

image

@sixhours I've also removed tumblr.com/username from the placeholder because of the questionable content you mentioned here (#89548 (comment)) and added a safe URL from PCYsg-eI0-p2

Link to Figma: https://www.figma.com/file/5yhaC6umexdQLlLpCrCyEe/Migrations?type=design&node-id=2863-13707&mode=design&t=neorvIWYNSg804vk-4

@alvezfrancese
Copy link

Looking good, @javierarce!

@gabrielcaires gabrielcaires added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging and removed DO NOT MERGE labels Apr 18, 2024
@gabrielcaires gabrielcaires requested review from sixhours and a team and removed request for a team April 18, 2024 15:58
Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrielcaires
Copy link
Contributor Author

Waiting for the translations to be deployed, it will probably happen today.

@gabrielcaires gabrielcaires removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Apr 25, 2024
@gabrielcaires gabrielcaires merged commit 7e5cb35 into trunk Apr 25, 2024
8 checks passed
@gabrielcaires gabrielcaires deleted the origin/update/import-capture-refactor branch April 25, 2024 08:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Migration Features related to site migrations to WPcom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants