Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Automattic for Agencies: Implement referrals API endpoints #89781

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Apr 23, 2024

Resolves https://github.com/Automattic/jetpack-genesis/issues/326
Resolves https://github.com/Automattic/jetpack-genesis/issues/327

Proposed Changes

TBD

Testing Instructions

  1. Open the A4A live link.
  2. TBD

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin self-assigned this Apr 23, 2024
@matticbot
Copy link
Contributor

matticbot commented Apr 23, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/implement-referral-api-endpoints on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Apr 23, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~508 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
a8c-for-agencies-referrals      +1464 B  (+1.1%)     +508 B  (+1.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin force-pushed the add/a4a/implement-referral-api-endpoints branch from 09a8eca to 1c86ff6 Compare April 23, 2024 08:18
@yashwin yashwin force-pushed the add/a4a/implement-referral-api-endpoints branch from 1c86ff6 to 4040c93 Compare April 23, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants