Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSV: Fix the extra spacing at the bottom #90024

Merged

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Apr 29, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/6786, https://github.com/Automattic/dotcom-forge/issues/6788

Proposed Changes

  • Fix the extra spacing at the bottom of the fly-out panel
Before After
image image
image image

Testing Instructions

  • Go to /sites?flags=layout/dotcom-nav-redesign-v2
  • Open GSV
  • Make sure the extra padding is gone

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Apr 29, 2024
@arthur791004 arthur791004 force-pushed the nav-redesign/too-much-paddding-after-the-fly-out-panel branch from 9ca2128 to 924055c Compare April 29, 2024 10:06
@arthur791004 arthur791004 requested review from a team April 29, 2024 10:09
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 29, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee

Copy link
Contributor

@candy02058912 candy02058912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I do wonder what the initial height restriction was for 🤔

@DustyReagan DustyReagan merged commit 668c5ea into trunk Apr 29, 2024
15 checks passed
@DustyReagan DustyReagan deleted the nav-redesign/too-much-paddding-after-the-fly-out-panel branch April 29, 2024 15:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants