Add is-selected to /sites on initial open preview pane #90028
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/dotcom-forge/issues/6782
Proposed Changes
This PR does direct DOM manipulation to add the
is-selected
class.Before
See video in https://github.com/Automattic/dotcom-forge/issues/6782
After
See video in https://github.com/Automattic/dotcom-forge/issues/6782#issuecomment-2082467258
This is to prevent leakage of internal P2 URLs.
Notes
@wordpress/dataviews
package located here.@wordpress/dataviews
, probably due to upgrading it might cause issues (Jetpack Manage: Lock the package "@wordpress/dataviews" to version 0.4.1 #87956)Know Issues
Will need to wait until https://github.com/Automattic/dotcom-forge/issues/6803 is fixed for pagination-related issues.
Testing Instructions
/sites?flags=layout/dotcom-nav-redesign-v2
Try to break it.
Pre-merge Checklist