Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Update Marketplace's Hosting card design and copies #90030

Merged
merged 9 commits into from Apr 29, 2024

Conversation

jkguidaven
Copy link
Contributor

@jkguidaven jkguidaven commented Apr 29, 2024

This PR updates the current Hosting card to follow the new design and copies. Note that copies are based on the latest discussion. https://github.com/Automattic/automattic-for-agencies-dev/issues/379

Before After
Screenshot 2024-04-29 at 7 49 24 PM Screenshot 2024-04-29 at 7 49 32 PM

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/361

Proposed Changes

  • Rearranged the Pressable and WPCOM hosting card positions based on the latest discussion.
  • Rearranged the description and price info based on the latest discussion.
  • Add a feature list to the card. I also added a shared simple list that can be used across the marketplace section.
  • Update some copies based on the latest discussion.

Testing Instructions

  • Use the A4A live link below and go to /marketplace/hosting?flags=a8c-for-agencies/wpcom-creator-plan-purchase-flow
  • Confirm that the card design follows the new design and copies.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven self-assigned this Apr 29, 2024
@jkguidaven jkguidaven requested a review from a team April 29, 2024 11:55
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 29, 2024
@jkguidaven jkguidaven marked this pull request as ready for review April 29, 2024 11:55
@matticbot
Copy link
Contributor

matticbot commented Apr 29, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~210 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +679 B  (+0.0%)     +210 B  (+0.0%)
entry-main                  +679 B  (+0.0%)     +210 B  (+0.0%)
entry-subscriptions         +463 B  (+0.0%)     +185 B  (+0.0%)
entry-login                 +463 B  (+0.0%)     +185 B  (+0.0%)
entry-domains-landing       +463 B  (+0.1%)     +185 B  (+0.1%)
entry-browsehappy           +463 B  (+0.3%)     +185 B  (+0.4%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2077 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace      +4379 B  (+0.9%)    +2064 B  (+1.4%)
a8c-for-agencies-overview          +223 B  (+0.1%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@vitozev vitozev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected and the code changes makes sense to me!

@vitozev vitozev merged commit f4be29b into trunk Apr 29, 2024
11 checks passed
@vitozev vitozev deleted the add/a4a/hosting-card-feature-list branch April 29, 2024 17:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants