Subscriptions: Add the Subscriber Login navigation placement toggle

[pkuliga]

Related to peKye1-EA-p2

Proposed Changes

It adds the Subscriber Login navigation placement toggle.

Blocked by Automattic/jetpack#37123

Testing Instructions

1. Go to Newsletter Settings
2. Make sure the toggle and "Preview and edit" link works as expected

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-106952

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-106952&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-106952&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~141 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
settings-newsletter        +952 B  (+0.2%)     +124 B  (+0.1%)
settings-reading           +281 B  (+0.1%)      +39 B  (+0.0%)
settings-writing           +181 B  (+0.0%)      +22 B  (+0.0%)
settings-security          +181 B  (+0.0%)      +22 B  (+0.0%)
settings-podcast           +181 B  (+0.0%)      +22 B  (+0.0%)
settings-performance       +181 B  (+0.0%)      +22 B  (+0.0%)
settings-discussion        +181 B  (+0.0%)      +22 B  (+0.0%)
settings                   +181 B  (+0.0%)      +22 B  (+0.0%)
people                     +181 B  (+0.0%)      +22 B  (+0.0%)
marketing                  +181 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[lezama]

Looks good!

The "Preview and Edit" link takes me here:

I don't see any Login Block there 😅

[pkuliga]

Ah, in this case, the navigation is hidden by default. You need to click the icon in the top-right corner to see it.

It's not that obvious, I know...

[lezama]

🚢

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/subscriber-login-toggle on your sandbox.