Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Add the WPCOM Hosting standard feature list. #90044

Merged
merged 3 commits into from Apr 30, 2024

Conversation

jkguidaven
Copy link
Contributor

@jkguidaven jkguidaven commented Apr 29, 2024

Add WPCOM Hosting features list.

Screenshot 2024-04-29 at 10 30 27 PM

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/371

Proposed Changes

  • Convert the Existing Pressable feature list component to a reusable one.
  • Reuse the same component to build the WPCOM Hosting feature list.
  • Additional: Fix broken content in the Pressable page.

Testing Instructions

  • Use the A4A live link and go to /marketplace/hosting/wpcom
  • Confirm that the standard feature list is visible at the bottom of the page.
  • Now go to /marketplace/hosting/pressable.
  • Confirm that the Feature list is no longer broken.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven self-assigned this Apr 29, 2024
@matticbot
Copy link
Contributor

matticbot commented Apr 29, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~625 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace       +962 B  (+0.2%)     +625 B  (+0.4%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jkguidaven jkguidaven force-pushed the add/a4a/wpcom-hosting-features branch from 90a019e to fdaa6c6 Compare April 29, 2024 14:25
@jkguidaven jkguidaven requested a review from a team April 29, 2024 14:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 29, 2024
@jkguidaven jkguidaven changed the title A4A: Add WPCOM Hosting features A4A: Add the WPCOM Hosting standard feature list. Apr 29, 2024
@jkguidaven jkguidaven marked this pull request as ready for review April 29, 2024 14:33
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, code looks good, nice introduction of the HostingOverviewFeatures component 🚢

@nateweller nateweller added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 29, 2024
@nateweller nateweller force-pushed the add/a4a/wpcom-hosting-features branch from fdaa6c6 to afdfe2c Compare April 29, 2024 18:57
@nateweller
Copy link
Contributor

Rebased trunk to resolve the merge conflicts.

@jkguidaven jkguidaven force-pushed the add/a4a/wpcom-hosting-features branch from 7749d9a to 4c1f999 Compare April 30, 2024 03:15
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/wpcom-hosting-features on your sandbox.

@jkguidaven jkguidaven merged commit 9806b46 into trunk Apr 30, 2024
11 checks passed
@jkguidaven jkguidaven deleted the add/a4a/wpcom-hosting-features branch April 30, 2024 03:46

<HostingOverview
title={ translate( 'Powerful development & platform tools' ) }
subtitle={ translate( 'Build for developers, by developers' ) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo: Build --> Built

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I will fix this on the next PR. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants