A4A: Updates to get Site Details pane fully functional

[rcoll]

Proposed Changes

• This PR removes the custom tags and tag field implementation in A4A, and instead uses the WordPress FormTokenField component that is native to both WordPress and Calypso.
• We also decided to go ahead and get site notes wired up and working.

Testing Instructions

Load the site tags field for an A4A site (inside site details pane) and check:

• Existing tags load with the page.
• New tags get submitted in the network request.
• Removing tags actually removes them.
• A reload maintains the actual state of the site tags.

Also, while you're there, you might as well test the notes field also:

• Submitting a note works, shows up immediately, and persists upon refresh.
• Styles/design of the notes are roughly okay.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[matticbot]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107605

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107605&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107605&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~34 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               -166 B  (-0.0%)      -34 B  (-0.0%)
entry-main                  -166 B  (-0.0%)      -34 B  (-0.0%)
entry-subscriptions         -146 B  (-0.0%)      -24 B  (-0.0%)
entry-login                 -146 B  (-0.0%)      -24 B  (-0.0%)
entry-domains-landing       -146 B  (-0.0%)      -24 B  (-0.0%)
entry-browsehappy           -146 B  (-0.1%)      -24 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~9455 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
a8c-for-agencies-sites     +20671 B  (+1.4%)    +5923 B  (+1.5%)
import-flow                   -20 B  (-0.0%)       -3 B  (-0.0%)
devdocs                       -20 B  (-0.0%)       +2 B  (+0.0%)
backup                        -14 B  (-0.0%)     -705 B  (-0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~96 bytes removed 📉 [gzipped])

name                                                                         parsed_size           gzip_size
async-load-design-wordpress-components-gallery                                     +58 B  (+0.0%)      -86 B  (-0.0%)
async-load-automattic-global-styles-src-components-global-styles-variations        -20 B  (-0.0%)       -4 B  (-0.0%)
async-load-automattic-design-preview                                               -20 B  (-0.0%)       -6 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[atanas-dev]

If it's a textarea wouldn't people want to insert newlines?

[jeffgolenski]

Just a couple notes (see what I did there?). Tested on live branch. Behavior is weird when jumping between sites. Avatar, name, date not showing up.

tags-notes-testinmg.mp4

[atanas-dev]

I'll take over and push some updates to address feedback with a minimal time investment.

[atanas-dev]

@jeffgolenski @rcoll I've refactored the patch - can you folks please give it another test? Thanks!