Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Manager: Add Switch account link #90222

Merged
merged 1 commit into from
May 6, 2024

Conversation

lezama
Copy link
Contributor

@lezama lezama commented May 2, 2024

Related to Automattic/jetpack#36504

Proposed Changes

Before:
Screenshot 2024-05-02 at 11 30 09 AM

After:
Screenshot 2024-05-02 at 12 16 07 PM

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@lezama lezama requested a review from a team as a code owner May 2, 2024 17:25
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 2, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~648 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions        +3569 B  (+0.2%)    +1143 B  (+0.2%)
entry-stepper                +39 B  (+0.0%)     -152 B  (-0.0%)
entry-main                   +39 B  (+0.0%)     -142 B  (-0.0%)
entry-login                  +39 B  (+0.0%)     -143 B  (-0.0%)
entry-domains-landing        +26 B  (+0.0%)     -111 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Async-loaded Components (~55 bytes added 📈 [gzipped])

name                                         parsed_size           gzip_size
async-load-calypso-reader-site-subscription       +137 B  (+0.8%)      +55 B  (+0.9%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@simison simison requested a review from crisbusquets May 6, 2024 11:47
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and fine to merge but @crisbusquets you could take a look at the copy/design to see if can have something smother looking?

@lezama lezama merged commit 03e0233 into trunk May 6, 2024
15 of 16 checks passed
@lezama lezama deleted the update/subscription-not-found branch May 6, 2024 12:31
@github-actions github-actions bot removed [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 6, 2024
@crisbusquets
Copy link
Contributor

Approving and fine to merge but @crisbusquets you could take a look at the copy/design to see if can have something smother looking?

@simison @lezama this works for me as a first iteration. The only think I would change is to underline the line (accessibility).

I've opened an issue to iterate the message and add more context: #90460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants