Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Studio to Developer Features page #90397

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

matt-west
Copy link
Contributor

@matt-west matt-west commented May 7, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/6982

Proposed Changes

  • Add Studio to the Developer Features page /me/developer

image

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matt-west matt-west self-assigned this May 7, 2024
@matticbot
Copy link
Contributor

matticbot commented May 7, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~132 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
developer       +938 B  (+0.1%)     +132 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@wongasy
Copy link
Contributor

wongasy commented May 7, 2024

@michaelpick It'd be great if you could kindly review the copy before we slap on the String Freeze label to get the copy translated!

Studio by WordPress.com
A fast, free way to develop locally with WordPress. Share your local sites with clients or colleagues and keep your local development process smooth and simple.

@michaelpick
Copy link
Contributor

Sure, @wongasy! We'll take a look ASAP.

@michaelpick
Copy link
Contributor

Actually, this looks familiar @wongasy, maybe something we looked at previously in a different request! Either way, I think it works well! Happy for this to ship 🚢!

@wongasy
Copy link
Contributor

wongasy commented May 7, 2024

@michaelpick Thanks for taking a second look :) I'll slap on the string freeze label :)

@wongasy wongasy added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 7, 2024
@wongasy wongasy marked this pull request as ready for review May 28, 2024 23:30
@wongasy wongasy force-pushed the add/studio-to-developer-features branch from f3258bf to 748d4c6 Compare May 28, 2024 23:33
Copy link
Contributor

@wongasy wongasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Studio card rendered as expected:

Desktop Mobile
Screen Shot 2024-05-29 at 8 07 45 AM Screen Shot 2024-05-29 at 8 07 53 AM

The learn more link takes users to the Studio landing page and triggers the expected tracks event:

Screen Shot 2024-05-29 at 8 05 23 AM

@wongasy wongasy merged commit cc37821 into trunk May 29, 2024
11 checks passed
@wongasy wongasy deleted the add/studio-to-developer-features branch May 29, 2024 16:12
@github-actions github-actions bot removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants