-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Redesign v2: fix horizontal table scrolling #90420
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~27 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~81 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@roo2 I'm not seeing horizontal scrolling at all on staging. Here's what I'm seeing: CleanShot.2024-05-08.at.10.54.01.mp4 |
@davemart-in It's just at certain intermediate widths, it looks like your browser isn't showing the horizontal scrollbar for some reaosn. But it is still pushing the Actions menu off screen Try at 1281px for example: Screen.Recording.2024-05-09.at.9.18.50.am.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well for me 👍
Another set of eyes might help review CSS. CC: @arthur791004
74f4dd4
to
44b2553
Compare
I've updated to use breakpoints in the table so that we can move away from 45% everywhere. I've made some other tweaks on mobile. Screen.Recording.2024-05-10.at.11.26.44.am.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this! It's definitely better than what we have in production today.
44b2553
to
4f9d0b7
Compare
Fixes 6972-gh-Automattic/dotcom-forge, removes horizontal table scrolling by setting widths on certain columns and reducing padding at certain breakpoints.
It's a bit of a balancing act to get everything looking good at various screen widths (and still be aligned properly)
This should prevent any horizontal scroling and ensure the table cells always have enough room. from 1600px+, down to 375px wide.
Screen.Recording.2024-05-08.at.4.20.07.pm.mov
Testing instructions
test /sites page on different screen resolutions and browsers etc.