Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Redesign v2: fix horizontal table scrolling #90420

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

roo2
Copy link
Contributor

@roo2 roo2 commented May 8, 2024

Fixes 6972-gh-Automattic/dotcom-forge, removes horizontal table scrolling by setting widths on certain columns and reducing padding at certain breakpoints.

It's a bit of a balancing act to get everything looking good at various screen widths (and still be aligned properly)

This should prevent any horizontal scroling and ensure the table cells always have enough room. from 1600px+, down to 375px wide.

Screen.Recording.2024-05-08.at.4.20.07.pm.mov

Testing instructions

test /sites page on different screen resolutions and browsers etc.

@roo2 roo2 requested review from arthur791004 and a team May 8, 2024 06:23
@roo2 roo2 self-assigned this May 8, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 8, 2024
@matticbot
Copy link
Contributor

matticbot commented May 8, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/sites-horizontal-scroll on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented May 8, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~27 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-subscriptions        +21 B  (+0.0%)      +15 B  (+0.0%)
entry-stepper              +21 B  (+0.0%)      +18 B  (+0.0%)
entry-main                 +21 B  (+0.0%)      +18 B  (+0.0%)
entry-login                +21 B  (+0.0%)      +18 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~81 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
sites-dashboard          +191 B  (+0.0%)      +81 B  (+0.0%)
site-monitoring          +191 B  (+0.0%)      +81 B  (+0.0%)
hosting                  +191 B  (+0.0%)      +81 B  (+0.0%)
github-deployments       +191 B  (+0.0%)      +81 B  (+0.0%)
dev-tools-promo          +191 B  (+0.0%)      +81 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@davemart-in
Copy link
Contributor

@roo2 I'm not seeing horizontal scrolling at all on staging. Here's what I'm seeing:

CleanShot.2024-05-08.at.10.54.01.mp4

@roo2
Copy link
Contributor Author

roo2 commented May 8, 2024

@davemart-in It's just at certain intermediate widths, it looks like your browser isn't showing the horizontal scrollbar for some reaosn. But it is still pushing the Actions menu off screen

Try at 1281px for example:

Screen.Recording.2024-05-09.at.9.18.50.am.mov

Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well for me 👍
Another set of eyes might help review CSS. CC: @arthur791004

@mmtr
Copy link
Member

mmtr commented May 9, 2024

Is there any way we can avoid fixing the site column width at 45%? It seems that we have more than enough room to display all the text:

Screenshot 2024-05-09 at 11 42 32

@roo2 roo2 force-pushed the fix/sites-horizontal-scroll branch from 74f4dd4 to 44b2553 Compare May 10, 2024 01:24
@roo2
Copy link
Contributor Author

roo2 commented May 10, 2024

I've updated to use breakpoints in the table so that we can move away from 45% everywhere. I've made some other tweaks on mobile.

Screen.Recording.2024-05-10.at.11.26.44.am.mov

Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this! It's definitely better than what we have in production today.

@roo2 roo2 force-pushed the fix/sites-horizontal-scroll branch from 44b2553 to 4f9d0b7 Compare May 13, 2024 02:38
@roo2 roo2 merged commit b39ffeb into trunk May 13, 2024
11 checks passed
@roo2 roo2 deleted the fix/sites-horizontal-scroll branch May 13, 2024 02:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants