Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the second plan-term selector on mobile #90421

Merged
merged 1 commit into from
May 16, 2024

Conversation

oswian
Copy link
Contributor

@oswian oswian commented May 8, 2024

Resolves #90362

Proposed Changes

Fixes the overlapping plan-term selectors on mobile by hiding the second instance. The second selector is redundant anyway, as there's another selector pinned to the top of the viewport.

Testing Instructions

  1. Load /start/plans
  2. Enable mobile viewport
  3. Scroll down to the comparison grid
  4. Check that the second plan-term selector is not displayed
  5. Enable desktop viewport
  6. Check that the second plan-term selector is displayed
Desktop (displayed) Mobile (not displayed)
CleanShot 2024-05-08 at 16 36 59@2x CleanShot 2024-05-08 at 16 37 25@2x

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@oswian oswian self-assigned this May 8, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@oswian oswian marked this pull request as ready for review May 8, 2024 06:44
@oswian oswian requested review from a team and southp May 8, 2024 06:44
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2024
@oswian
Copy link
Contributor Author

oswian commented May 8, 2024

The failing E2E tests don't appear to be related to this change.

Copy link
Contributor

@southp southp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described and LGTM 🚢

@oswian oswian force-pushed the update/hide-second-term-selector-on-mobile branch from edace6d to dbc3078 Compare May 15, 2024 23:46
@oswian
Copy link
Contributor Author

oswian commented May 16, 2024

Thanks for the review @southp.

I just rebased and it has fixed the failing E2E tests ✅

@oswian oswian merged commit 8a04f73 into trunk May 16, 2024
11 checks passed
@oswian oswian deleted the update/hide-second-term-selector-on-mobile branch May 16, 2024 00:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Term selectors are overlapping on mobile
3 participants