-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for supported engines to import CaptureStep #90625
Add check for supported engines to import CaptureStep #90625
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~544 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This doesn't seem to fix the issue Screen.Recording.2024-05-13.at.09.14.05.mov |
@andres-blanco, did you follow the flow from the start? It shouldn't take you to the preview step after entering the URL -- you should end up on a step saying that we can't import your content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Noting that we should consolidate the list of supported importers, more on this in this thread p1715595249244569-slack-C0Q664T29
I created #90635 to track the divergent lists of available importers. |
Proposed Changes
Testing Instructions
/setup/import-hosted-site
*.godaddysites.com
)Pre-merge Checklist