-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepper Migration: Add user step to the hosting flow #90680
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~2930 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~15152 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1337 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
29b498e
to
3320e0f
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
I am merging these changes behind a feature flag so that I can investigate more deeply in production/wpcalypso. There is relatively low impact to previous change and the only risky change is done here where a callback was raised to the parent level to delegate error handling to the caller. Please feel free to revert this change if there is any impactful breaking change. Also please feel free to leave a review which I can followup on immediately. |
Related to #
Proposed Changes
new-hosted-site-user-included
to experiment with adding the user step to the hosting flow without breaking the existing implementationonboarding/user-on-stepper-hosting
if landed on flow without feature flag, the user will be redirected tonew-hosted-site
flow<PasswordlessSignupForm />
component so that consuming client code can implement redirect side effects either with page.js or any other preferred mechanism.Why are these changes being made?
Testing Instructions
Scenarios
Pre-merge Checklist