Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Redesign: Hide search and notifications on mobile #90732

Merged
merged 1 commit into from
May 15, 2024

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented May 15, 2024

Proposed Changes

We now hide the notifications and search on mobile from the sidebar, since they are already present in the top bar.

Before After
Screenshot 2024-05-15 at 10 21 51 Screenshot 2024-05-15 at 10 21 58

Why are these changes being made?

Because we have duplicated elements in the UI.

Testing Instructions

  • Use the Calypso live link below
  • Switch to a mobile viewport
  • Go to /sites
  • Open the sidebar
  • Make sure the search and notifications don't appear in the footer

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mmtr mmtr requested a review from a team as a code owner May 15, 2024 08:13
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2024
@mmtr mmtr changed the title Fix/notifications nav redesign Nav Redesign: Hide search and notifications on mobile May 15, 2024
@matticbot
Copy link
Contributor

matticbot commented May 15, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/notifications-nav-redesign on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented May 15, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~11 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
woocommerce-installation                 +53 B  (+0.0%)      +11 B  (+0.0%)
woocommerce                              +53 B  (+0.0%)      +11 B  (+0.0%)
themes                                   +53 B  (+0.0%)      +11 B  (+0.0%)
theme                                    +53 B  (+0.0%)      +11 B  (+0.0%)
subscribers                              +53 B  (+0.0%)      +11 B  (+0.0%)
stats                                    +53 B  (+0.0%)      +11 B  (+0.0%)
sites-dashboard                          +53 B  (+0.0%)      +11 B  (+0.0%)
site-purchases                           +53 B  (+0.0%)      +11 B  (+0.0%)
site-monitoring                          +53 B  (+0.0%)      +11 B  (+0.0%)
site-blocks                              +53 B  (+0.0%)      +11 B  (+0.0%)
settings-writing                         +53 B  (+0.0%)      +11 B  (+0.0%)
settings-security                        +53 B  (+0.0%)      +11 B  (+0.0%)
settings-reading                         +53 B  (+0.0%)      +11 B  (+0.0%)
settings-podcast                         +53 B  (+0.0%)      +11 B  (+0.0%)
settings-performance                     +53 B  (+0.0%)      +11 B  (+0.0%)
settings-newsletter                      +53 B  (+0.0%)      +11 B  (+0.0%)
settings-jetpack                         +53 B  (+0.0%)      +11 B  (+0.0%)
settings-discussion                      +53 B  (+0.0%)      +11 B  (+0.0%)
settings                                 +53 B  (+0.0%)      +11 B  (+0.0%)
security                                 +53 B  (+0.0%)      +11 B  (+0.0%)
scan                                     +53 B  (+0.0%)      +11 B  (+0.0%)
purchases                                +53 B  (+0.0%)      +11 B  (+0.0%)
promote-post-i2                          +53 B  (+0.0%)      +11 B  (+0.0%)
privacy                                  +53 B  (+0.0%)      +11 B  (+0.0%)
preview                                  +53 B  (+0.0%)      +11 B  (+0.0%)
posts-custom                             +53 B  (+0.0%)      +11 B  (+0.0%)
posts                                    +53 B  (+0.0%)      +11 B  (+0.0%)
plugins                                  +53 B  (+0.0%)      +11 B  (+0.0%)
plans                                    +53 B  (+0.0%)      +11 B  (+0.0%)
people                                   +53 B  (+0.0%)      +11 B  (+0.0%)
pages                                    +53 B  (+0.0%)      +11 B  (+0.0%)
notification-settings                    +53 B  (+0.0%)      +11 B  (+0.0%)
migrate                                  +53 B  (+0.0%)      +11 B  (+0.0%)
media                                    +53 B  (+0.0%)      +11 B  (+0.0%)
me                                       +53 B  (+0.0%)      +11 B  (+0.0%)
marketplace                              +53 B  (+0.0%)      +11 B  (+0.0%)
marketing                                +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-social                           +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-search                           +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-connect                          +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-settings                   +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-pricing                    +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-plugin-management          +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-overview                   +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-features-comparison        +53 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud                            +53 B  (+0.0%)      +11 B  (+0.0%)
import                                   +53 B  (+0.0%)      +11 B  (+0.0%)
hosting                                  +53 B  (+0.0%)      +11 B  (+0.0%)
home                                     +53 B  (+0.0%)      +11 B  (+0.0%)
help                                     +53 B  (+0.0%)      +11 B  (+0.0%)
gutenberg-editor                         +53 B  (+0.0%)      +11 B  (+0.0%)
google-my-business                       +53 B  (+0.0%)      +11 B  (+0.0%)
github-deployments                       +53 B  (+0.0%)      +11 B  (+0.0%)
export                                   +53 B  (+0.0%)      +11 B  (+0.0%)
email                                    +53 B  (+0.0%)      +11 B  (+0.0%)
earn                                     +53 B  (+0.0%)      +11 B  (+0.0%)
domains                                  +53 B  (+0.0%)      +11 B  (+0.0%)
developer                                +53 B  (+0.0%)      +11 B  (+0.0%)
dev-tools-promo                          +53 B  (+0.0%)      +11 B  (+0.0%)
customize                                +53 B  (+0.0%)      +11 B  (+0.0%)
concierge                                +53 B  (+0.0%)      +11 B  (+0.0%)
comments                                 +53 B  (+0.0%)      +11 B  (+0.0%)
checkout                                 +53 B  (+0.0%)      +11 B  (+0.0%)
backup                                   +53 B  (+0.0%)      +11 B  (+0.0%)
add-ons                                  +53 B  (+0.0%)      +11 B  (+0.0%)
activity                                 +53 B  (+0.0%)      +11 B  (+0.0%)
account-close                            +53 B  (+0.0%)      +11 B  (+0.0%)
account                                  +53 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~11 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-calypso-reader-sidebar        +53 B  (+0.0%)      +11 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mmtr mmtr added [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 15, 2024
@mmtr mmtr force-pushed the fix/notifications-nav-redesign branch from cca79e6 to 18a7c27 Compare May 15, 2024 08:59
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2024
@mmtr mmtr requested a review from a team May 15, 2024 09:01
@mmtr mmtr merged commit 7d1c7e1 into trunk May 15, 2024
14 checks passed
@mmtr mmtr deleted the fix/notifications-nav-redesign branch May 15, 2024 11:19
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants