-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Migrations: Update import flow reference on /sites
dashboard
#90904
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~56 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
client/sites-dashboard/hooks/use-sites-dashboard-import-site-url.ts
Outdated
Show resolved
Hide resolved
I noticed you mentioned a I was able to find these two references:
But those add a |
Ahh the reason you can't find it is because it's supposed to be
We could! I'm wondering if that could affect tracking for other projects, though. I'm inclined to leave them alone as long as we know we have some kind of |
Great, let's do that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #90652 and https://github.com/Automattic/dotcom-forge/issues/7237
Proposed Changes
/start/import
to/setup/hosted-site-migration
when coming from the/sites
dashboard.Tracking
We can follow the
calypso_sites_dashboard_new_site_action_click_import
event with acalypso_signup_start
:flow: site-migration
as a parameter to track incoming hits to this flow from the Site Dashboard.There's also a
?source=sites-dashboard
and?ref=topbar
query params carried over in the URL.Why are these changes being made?
This is part of a project to redirect all references of
/start/import
to/setup/hosted-site-migration
to leverage Migrate Guru for more reliable imports. paYKcK-4BA-p2Testing Instructions
/sites
/setup/hosted-site-migration
Pre-merge Checklist