Changed the command palette icon to the one provided by design

[rcrdortiz]

Related to

• Consider the icon for the command palette #89578
• Command palette tooltip #90930

Proposed Changes

• Changed the icon from a magnifying glass to the one provided by design.
• Changed the tooltip.

Why are these changes being made?

• The magnifying glass icon doesn't have the expected engagement since users do not associate it with the command palette, by changing the icon we want to increase the engagement.

Testing Instructions

• Open the Calypso live link
• visit /sites
• You should see that the icon corresponds with the new icon instead of the magnifying glass.
• The tooltip should have the updated text corresponding with the new icon.

Before:

After:

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108718

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108718&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108718&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~198 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +628 B  (+0.0%)     +198 B  (+0.0%)
entry-main          +628 B  (+0.0%)     +198 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2 bytes removed 📉 [gzipped])

name                               parsed_size           gzip_size
woocommerce-installation                 -91 B  (-0.0%)       -2 B  (-0.0%)
woocommerce                              -91 B  (-0.0%)       -2 B  (-0.0%)
themes                                   -91 B  (-0.0%)       -2 B  (-0.0%)
theme                                    -91 B  (-0.0%)       -2 B  (-0.0%)
subscribers                              -91 B  (-0.0%)       -2 B  (-0.0%)
stats                                    -91 B  (-0.0%)       -2 B  (-0.0%)
sites-dashboard                          -91 B  (-0.0%)       -2 B  (-0.0%)
site-purchases                           -91 B  (-0.0%)       -2 B  (-0.0%)
site-monitoring                          -91 B  (-0.0%)       -2 B  (-0.0%)
site-blocks                              -91 B  (-0.0%)       -2 B  (-0.0%)
settings-writing                         -91 B  (-0.0%)       -2 B  (-0.0%)
settings-security                        -91 B  (-0.0%)       -2 B  (-0.0%)
settings-reading                         -91 B  (-0.0%)       -2 B  (-0.0%)
settings-podcast                         -91 B  (-0.0%)       -2 B  (-0.0%)
settings-performance                     -91 B  (-0.0%)       -2 B  (-0.0%)
settings-newsletter                      -91 B  (-0.0%)       -2 B  (-0.0%)
settings-jetpack                         -91 B  (-0.0%)       -2 B  (-0.0%)
settings-discussion                      -91 B  (-0.0%)       -2 B  (-0.0%)
settings                                 -91 B  (-0.0%)       -2 B  (-0.0%)
security                                 -91 B  (-0.0%)       -2 B  (-0.0%)
scan                                     -91 B  (-0.0%)       -2 B  (-0.0%)
purchases                                -91 B  (-0.0%)       -2 B  (-0.0%)
promote-post-i2                          -91 B  (-0.0%)       -2 B  (-0.0%)
privacy                                  -91 B  (-0.0%)       -2 B  (-0.0%)
preview                                  -91 B  (-0.0%)       -2 B  (-0.0%)
posts-custom                             -91 B  (-0.0%)       -2 B  (-0.0%)
posts                                    -91 B  (-0.0%)       -2 B  (-0.0%)
plugins                                  -91 B  (-0.0%)       -2 B  (-0.0%)
plans                                    -91 B  (-0.0%)       -2 B  (-0.0%)
people                                   -91 B  (-0.0%)       -2 B  (-0.0%)
pages                                    -91 B  (-0.0%)       -2 B  (-0.0%)
notification-settings                    -91 B  (-0.0%)       -2 B  (-0.0%)
migrate                                  -91 B  (-0.0%)       -2 B  (-0.0%)
media                                    -91 B  (-0.0%)       -2 B  (-0.0%)
me                                       -91 B  (-0.0%)       -2 B  (-0.0%)
marketplace                              -91 B  (-0.0%)       -2 B  (-0.0%)
marketing                                -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-social                           -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-search                           -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-connect                          -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-cloud-settings                   -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-cloud-pricing                    -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-cloud-plugin-management          -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-cloud-overview                   -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-cloud-features-comparison        -91 B  (-0.0%)       -2 B  (-0.0%)
jetpack-cloud                            -91 B  (-0.0%)       -2 B  (-0.0%)
import                                   -91 B  (-0.0%)       -2 B  (-0.0%)
hosting                                  -91 B  (-0.0%)       -2 B  (-0.0%)
home                                     -91 B  (-0.0%)       -2 B  (-0.0%)
help                                     -91 B  (-0.0%)       -2 B  (-0.0%)
gutenberg-editor                         -91 B  (-0.0%)       -2 B  (-0.0%)
google-my-business                       -91 B  (-0.0%)       -2 B  (-0.0%)
github-deployments                       -91 B  (-0.0%)       -2 B  (-0.0%)
export                                   -91 B  (-0.0%)       -2 B  (-0.0%)
email                                    -91 B  (-0.0%)       -2 B  (-0.0%)
earn                                     -91 B  (-0.0%)       -2 B  (-0.0%)
domains                                  -91 B  (-0.0%)       -2 B  (-0.0%)
developer                                -91 B  (-0.0%)       -2 B  (-0.0%)
dev-tools-promo                          -91 B  (-0.0%)       -2 B  (-0.0%)
customize                                -91 B  (-0.0%)       -2 B  (-0.0%)
concierge                                -91 B  (-0.0%)       -2 B  (-0.0%)
comments                                 -91 B  (-0.0%)       -2 B  (-0.0%)
checkout                                 -91 B  (-0.0%)       -2 B  (-0.0%)
backup                                   -91 B  (-0.0%)       -2 B  (-0.0%)
add-ons                                  -91 B  (-0.0%)       -2 B  (-0.0%)
activity                                 -91 B  (-0.0%)       -2 B  (-0.0%)
account-close                            -91 B  (-0.0%)       -2 B  (-0.0%)
account                                  -91 B  (-0.0%)       -2 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2 bytes removed 📉 [gzipped])

name                               parsed_size           gzip_size
async-load-calypso-reader-sidebar        -91 B  (-0.0%)       -2 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[mmtr]

Looks great! However, the tooltip message seems to be based on the previous search icon. Should we change it to something else like "Open command palette"?

[rcrdortiz]

Looks great! However, the tooltip message seems to be based on the previous search icon. Should we change it to something else like "Open command palette"?

Yeah, I was working on that just now, that's why I removed the Needs review label from the PR.

[mmtr]

¡Perfecto!

[mmtr]

Actually, a minor thing. Seems that the icon is not using the same color as the other icons.

Command palette icon:

Notifications icon:

The notifications and help icons are using #2c3338 but the command palette uses #1E1E1E which is a bit darker.

[rcrdortiz]

Actually, a minor thing. Seems that the icon is not using the same color as the other icons.

Command palette icon:

Notifications icon:

The notifications and help icons are using #2c3338 but the command palette uses #1E1E1E which is a bit darker.

I copied the SVG from the icon library Figma file. I'll change the color so that all the icons share the same color.

[rcrdortiz]

@mmtr Changed the color.

[mmtr]

@mmtr Changed the color.

Thanks! Pushed another commit to rely on the CSS variable instead of hardcoding the color.

[mmtr]

Just realized that we have a different icon for mobile viewports in the header that needs to be replaced too:

[rcrdortiz]

Just realized that we have a different icon for mobile viewports in the header that needs to be replaced too:

Fixed, there were two different implementations that didn't share a common button. I've created a button component that we can re-use from other components to avoid needing to update n icons if it ever changes.