Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command palette: Make wider #91000

Merged
merged 1 commit into from
May 22, 2024
Merged

Command palette: Make wider #91000

merged 1 commit into from
May 22, 2024

Conversation

dsas
Copy link
Contributor

@dsas dsas commented May 22, 2024

Making the command palette wider than it is taller feels more natural for this kind of tool.

Related to #90931

Proposed Changes

Make the command palette wider - up to 640px depending upon the screen width..

Why are these changes being made?

Having it wider than it is taller feels more natural.

Testing Instructions

Calypso

  1. Use calypso live link
  2. Go to calypso page and invoke the command palette with ⌘k
  3. Look at the command palette using a variety of screen widths

wp-admin

  1. Use the automatically generated command below on your sandbox
  2. Sandbox widgets.wp.com
  3. Go to yoursite .wordpress.com/wp-admin and repeat as before

Edit: Weirdly the wp-admin install-plugin command hasn't been generated, it should be install-plugin.sh command-palette-wp-admin update/command-palette-width

Before After
Screenshot 2024-05-22 at 15 08 46 Screenshot 2024-05-22 at 15 09 07
Screen.Recording.2024-05-22.at.15.02.04.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Making the command palette wider than it is taller feels more natural
for this kind of tool.
@dsas dsas added Hosting Command Palette Launch Command Palette Planned project to polish the wpcom command palette labels May 22, 2024
@dsas dsas self-assigned this May 22, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@dsas dsas marked this pull request as ready for review May 22, 2024 14:29
Copy link
Contributor

@rcrdortiz rcrdortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@dsas dsas merged commit 6ba6829 into trunk May 22, 2024
13 checks passed
@dsas dsas deleted the update/command-palette-width branch May 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hosting Command Palette Launch Command Palette Planned project to polish the wpcom command palette
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants