WordAds: Include Inline Ads Setting #91006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
|
Coincidentally, I was working on this same task and was ready to push a PR almost identical to yours. The only difference was that I also included the option for non-Jetpack sites—since they should be able to toggle this as well. We can use your PR with a small update. Could you update your |
|
Whoops, sorry for the overlap! :) Ah, good point, completely missed that - should be fixed now. |
cphilleo
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90997
Proposed Changes
Adds the "Inline within post content" settings to the WordAds dashboard on Calypso.
Why are these changes being made?
These changes were already recently added to Jetpack in WP-Admin: Automattic/jetpack#37170. This PR brings parity with Calypso.
Testing Instructions
/earn/ads-settings/and confirm that the setting is listed there/wp-admin/admin.php?page=jetpack#/earn, and confirm that the toggle updates to match Calypso.