Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Help Center site picker - include domain only sites and throw when ZD widget is unavailable #91026

Merged
merged 1 commit into from
May 22, 2024

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented May 22, 2024

The Help Center queries /sites to get the user's sites and select a site automatically for the support session, when the user has none, we ask them to enter a site.

The query on trunk didn't include domain only sites, which made us ask the user and cause confusion.

This also throws an error when we try to open the chat widgets and the JS needed is not available. This would make debugging this much easier.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~152 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
update-design-flow                       +53 B  (+0.0%)      +34 B  (+0.0%)
site-purchases                           +53 B  (+0.0%)      +26 B  (+0.0%)
purchases                                +53 B  (+0.0%)      +26 B  (+0.0%)
plans                                    +53 B  (+0.0%)      +26 B  (+0.0%)
link-in-bio-tld-flow                     +53 B  (+0.0%)      +29 B  (+0.0%)
jetpack-connect                          +53 B  (+0.0%)      +26 B  (+0.0%)
jetpack-cloud-pricing                    +53 B  (+0.0%)      +26 B  (+0.0%)
jetpack-cloud-features-comparison        +53 B  (+0.0%)      +26 B  (+0.0%)
import-hosted-site-flow                  +53 B  (+0.0%)      +31 B  (+0.0%)
import-flow                              +53 B  (+0.0%)      +31 B  (+0.0%)
email                                    +53 B  (+0.0%)      +26 B  (+0.0%)
domains                                  +53 B  (+0.0%)      +26 B  (+0.0%)
copy-site-flow                           +53 B  (+0.0%)      +32 B  (+0.0%)
checkout                                 +53 B  (+0.0%)      +26 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~131 bytes added 📈 [gzipped])

name                                                            parsed_size           gzip_size
async-load-automattic-help-center                                     +80 B  (+0.0%)      +40 B  (+0.0%)
async-load-signup-steps-woocommerce-install-transfer                  +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-woocommerce-install-step-store-address        +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-woocommerce-install-step-business-info        +53 B  (+0.0%)      +34 B  (+0.1%)
async-load-signup-steps-woocommerce-install-confirm                   +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-website-content                               +53 B  (+0.0%)      +34 B  (+0.1%)
async-load-signup-steps-user                                          +53 B  (+0.0%)      +34 B  (+0.1%)
async-load-signup-steps-theme-selection                               +53 B  (+0.0%)      +34 B  (+0.0%)
async-load-signup-steps-test-step                                     +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-store-features                                +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-starting-point                                +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-social-profiles                               +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-site-picker                                   +53 B  (+0.0%)      +34 B  (+0.1%)
async-load-signup-steps-site-or-domain                                +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-site-options                                  +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-site                                          +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-rewind-were-backing                           +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-rewind-migrate                                +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-rewind-form-creds                             +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-reader-landing                                +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-plans-theme-preselected                       +53 B  (+0.0%)      +34 B  (+0.0%)
async-load-signup-steps-plans                                         +53 B  (+0.0%)      +34 B  (+0.0%)
async-load-signup-steps-page-picker                                   +53 B  (+0.0%)      +34 B  (+0.0%)
async-load-signup-steps-p2-site                                       +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-p2-join-workspace                             +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-p2-get-started                                +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-p2-details                                    +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-p2-confirm-email                              +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-p2-complete-profile                           +53 B  (+0.0%)      +34 B  (+0.1%)
async-load-signup-steps-new-user-survey                               +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-new-or-existing-site                          +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-intent                                        +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-initial-intent                                +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-hosting-decider                               +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-emails                                        +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-domains                                       +53 B  (+0.0%)      +34 B  (+0.0%)
async-load-signup-steps-difm-site-picker                              +53 B  (+0.0%)      +34 B  (+0.1%)
async-load-signup-steps-design-picker                                 +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-creds-permission                              +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-creds-confirm                                 +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-creds-complete                                +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-courses                                       +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-clone-start                                   +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-clone-ready                                   +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-clone-point                                   +53 B  (+0.0%)      +34 B  (+0.1%)
async-load-signup-steps-clone-jetpack                                 +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-clone-destination                             +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-clone-credentials                             +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-signup-steps-clone-cloning                                 +53 B  (+0.1%)      +34 B  (+0.2%)
async-load-signup-steps-add-ons                                       +53 B  (+0.1%)      +34 B  (+0.1%)
async-load-calypso-my-sites-checkout-modal                            +53 B  (+0.0%)      +26 B  (+0.0%)
async-load-calypso-components-jetpack-portal-nav                      +53 B  (+0.1%)      +31 B  (+0.2%)
async-load-calypso-blocks-editor-checkout-modal                       +53 B  (+0.0%)      +26 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@alshakero alshakero merged commit fd6505d into trunk May 22, 2024
11 of 13 checks passed
@alshakero alshakero deleted the fix/help-center-site-picker branch May 22, 2024 22:28
@alshakero alshakero changed the title Fix Help Center site picker - include domain only sites Fix Help Center site picker - include domain only sites and throw when ZD widget is unavailable May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants