Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Remove CTAs from Gravatar flow #91029

Merged

Conversation

rafaelgallani
Copy link
Contributor

@rafaelgallani rafaelgallani commented May 22, 2024

Proposed Changes

Prevents WordPress.com CTAs (set domain as primary, move domain to other site, map a domain, etc.) from being displayed in the Gravatar onboarding flow.

Why are these changes being made?

This is part of the Custom Domains on Gravatar project (pcYYhz-24z-p2).

Testing Instructions

  • Access the Calypso live page or build this branch locally;
  • Go to /start/domain-for-gravatar/domain-only?search=yes&new=your-test-domain.com;
  • Search for a WordPress.com domain that is registered in another site;
  • Try testing for both:
    • Search for a WordPress.com domain registration in a site you own;
    • Search for a standalone mapping in a WordPress.com site you own;
  • Ensure you get error messages without any CTA (same as in the "Preview" section).

Preview

WordPress.com domain registered in another site

image

Standalone mapping in another site

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@rafaelgallani rafaelgallani self-assigned this May 22, 2024
@matticbot
Copy link
Contributor

matticbot commented May 22, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/prevent-domain-move-and-mapping-cta-for-gravatar-flow on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented May 22, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~35 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
videopress-flow             +70 B  (+0.0%)      +35 B  (+0.0%)
update-design-flow          +70 B  (+0.0%)      +35 B  (+0.0%)
sensei-flow                 +70 B  (+0.0%)      +35 B  (+0.0%)
podcasts-flow               +70 B  (+0.0%)      +35 B  (+0.0%)
link-in-bio-tld-flow        +70 B  (+0.0%)      +35 B  (+0.0%)
domains                     +70 B  (+0.0%)      +35 B  (+0.0%)
copy-site-flow              +70 B  (+0.0%)      +35 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~35 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains        +70 B  (+0.0%)      +35 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@rafaelgallani rafaelgallani added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 23, 2024
@rafaelgallani
Copy link
Contributor Author

We don't need to add new code to prevent Gravatar domains from being displayed as the "Domain Move" row in the search results, as these are already filtered by our back-end code.

@rafaelgallani rafaelgallani marked this pull request as ready for review May 23, 2024 15:27
@rafaelgallani rafaelgallani requested a review from a team as a code owner May 23, 2024 15:27
Copy link
Contributor

@leonardost leonardost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works as expected! 🚀

@rafaelgallani rafaelgallani merged commit 2606fd7 into trunk Jun 3, 2024
14 checks passed
@rafaelgallani rafaelgallani deleted the add/prevent-domain-move-and-mapping-cta-for-gravatar-flow branch June 3, 2024 20:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 3, 2024
rafaelgallani added a commit that referenced this pull request Jun 3, 2024
rafaelgallani added a commit that referenced this pull request Jun 3, 2024
rafaelgallani added a commit that referenced this pull request Jun 4, 2024
rafaelgallani added a commit that referenced this pull request Jun 5, 2024
* Revert "Revert "Domains: Remove CTAs from Gravatar flow (#91029)" (#91431)"

This reverts commit 8ed11a9.

* Return early for Gravatar flow + revert availability message changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants