-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains: Remove CTAs from Gravatar flow #91029
Domains: Remove CTAs from Gravatar flow #91029
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~35 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~35 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
We don't need to add new code to prevent Gravatar domains from being displayed as the "Domain Move" row in the search results, as these are already filtered by our back-end code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and works as expected! 🚀
This reverts commit 2606fd7.
Proposed Changes
Prevents WordPress.com CTAs (set domain as primary, move domain to other site, map a domain, etc.) from being displayed in the Gravatar onboarding flow.
Why are these changes being made?
This is part of the Custom Domains on Gravatar project (pcYYhz-24z-p2).
Testing Instructions
/start/domain-for-gravatar/domain-only?search=yes&new=your-test-domain.com
;Preview
WordPress.com domain registered in another site
Standalone mapping in another site
Pre-merge Checklist