Nav Redesign: Remove notifications pointer

[mmtr]

Proposed Changes

Removes the notifications pointer added in #90495 since it was designed to show up only before May 23.

Why are these changes being made?

To clean up obsolete code.

Testing Instructions

This is actually untestable since the notifications pointer is no longer visible, so just use the Calypso live below, go to /sites and make sure there are no regressions.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108772

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108772&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-108772&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/sidebar-notifications-pointer on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~14 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions         +383 B  (+0.0%)      +96 B  (+0.0%)
entry-login                 +383 B  (+0.0%)      +96 B  (+0.0%)
entry-domains-landing       +383 B  (+0.1%)      +96 B  (+0.1%)
entry-browsehappy           +383 B  (+0.2%)      +96 B  (+0.1%)
entry-stepper               +103 B  (+0.0%)      -14 B  (-0.0%)
entry-main                   -72 B  (-0.0%)      -35 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~19903 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
settings-writing                       -2009 B  (-0.3%)    -1572 B  (-0.8%)
gutenberg-editor                       -1989 B  (-0.3%)     -555 B  (-0.3%)
woocommerce-installation               -1916 B  (-0.5%)     -530 B  (-0.4%)
woocommerce                            -1916 B  (-0.5%)     -530 B  (-0.4%)
site-blocks                            -1916 B  (-0.2%)     -530 B  (-0.2%)
settings-reading                       -1916 B  (-0.4%)     -530 B  (-0.4%)
settings-jetpack                       -1916 B  (-0.3%)     -530 B  (-0.3%)
settings-discussion                    -1916 B  (-0.4%)     -530 B  (-0.4%)
security                               -1916 B  (-0.2%)     -530 B  (-0.2%)
promote-post-i2                        -1916 B  (-0.4%)     -530 B  (-0.4%)
privacy                                -1916 B  (-0.2%)     -530 B  (-0.2%)
notification-settings                  -1916 B  (-0.2%)     -530 B  (-0.2%)
migrate                                -1916 B  (-0.5%)     -530 B  (-0.4%)
me                                     -1916 B  (-0.2%)     -530 B  (-0.2%)
marketplace                            -1916 B  (-0.2%)     -530 B  (-0.2%)
jetpack-social                         -1916 B  (-0.4%)     -293 B  (-0.2%)
jetpack-search                         -1916 B  (-0.3%)     -511 B  (-0.3%)
jetpack-connect                        -1916 B  (-0.2%)     -509 B  (-0.1%)
jetpack-cloud-settings                 -1916 B  (-0.3%)     -530 B  (-0.3%)
jetpack-cloud-pricing                  -1916 B  (-0.2%)     -541 B  (-0.2%)
jetpack-cloud-overview                 -1916 B  (-0.4%)     -530 B  (-0.3%)
jetpack-cloud-features-comparison      -1916 B  (-0.3%)     -597 B  (-0.3%)
jetpack-cloud                          -1916 B  (-0.4%)     -530 B  (-0.4%)
import                                 -1916 B  (-0.4%)     -530 B  (-0.3%)
help                                   -1916 B  (-0.2%)     -530 B  (-0.2%)
google-my-business                     -1916 B  (-0.4%)     -530 B  (-0.3%)
export                                 -1916 B  (-0.5%)     -530 B  (-0.4%)
developer                              -1916 B  (-0.2%)     -530 B  (-0.2%)
customize                              -1916 B  (-0.5%)     -530 B  (-0.4%)
concierge                              -1916 B  (-0.3%)     -530 B  (-0.3%)
comments                               -1916 B  (-0.2%)     -530 B  (-0.2%)
checkout                               -1916 B  (-0.1%)     -530 B  (-0.1%)
add-ons                                -1916 B  (-0.5%)     -530 B  (-0.4%)
account-close                          -1916 B  (-0.2%)     -530 B  (-0.2%)
account                                -1916 B  (-0.2%)     -530 B  (-0.2%)
scan                                   -1903 B  (-0.2%)     -518 B  (-0.2%)
preview                                -1881 B  (-0.5%)     -525 B  (-0.4%)
pages                                  -1881 B  (-0.3%)     -576 B  (-0.3%)
subscribers                            -1821 B  (-0.2%)     -498 B  (-0.2%)
settings-newsletter                    -1813 B  (-0.3%)     -434 B  (-0.3%)
home                                   -1811 B  (-0.1%)     -514 B  (-0.1%)
settings                               -1034 B  (-0.1%)     -629 B  (-0.3%)
plans                                  -1034 B  (-0.1%)    -1211 B  (-0.3%)
hosting                                -1034 B  (-0.1%)    -1006 B  (-0.2%)
site-purchases                         -1004 B  (-0.1%)     -850 B  (-0.2%)
purchases                              -1004 B  (-0.0%)     -850 B  (-0.1%)
github-deployments                      -931 B  (-0.1%)    -1167 B  (-0.4%)
sites-dashboard                         -838 B  (-0.1%)     -260 B  (-0.1%)
site-monitoring                         -838 B  (-0.1%)     -260 B  (-0.1%)
plugins                                 -838 B  (-0.0%)     -157 B  (-0.0%)
jetpack-cloud-plugin-management         -838 B  (-0.1%)     -211 B  (-0.0%)
dev-tools-promo                         -838 B  (-0.1%)     -260 B  (-0.1%)
settings-performance                    -815 B  (-0.1%)    +1879 B  (+1.1%)
settings-podcast                        -814 B  (-0.1%)    -2354 B  (-1.3%)
email                                   -808 B  (-0.1%)     -253 B  (-0.1%)
domains                                 -808 B  (-0.0%)      -23 B  (-0.0%)
backup                                  -808 B  (-0.1%)      -29 B  (-0.0%)
activity                                -808 B  (-0.1%)     -392 B  (-0.2%)
posts-custom                            -773 B  (-0.1%)     -422 B  (-0.2%)
posts                                   -773 B  (-0.1%)     -422 B  (-0.2%)
settings-security                       -757 B  (-0.1%)     +150 B  (+0.1%)
earn                                    -713 B  (-0.1%)     -513 B  (-0.2%)
stats                                   -695 B  (-0.1%)     -213 B  (-0.1%)
themes                                  -607 B  (-0.1%)     +753 B  (+0.2%)
theme                                   -607 B  (-0.1%)    +1509 B  (+0.6%)
media                                   -540 B  (-0.0%)    -1053 B  (-0.3%)
people                                  -509 B  (-0.1%)     +935 B  (+0.5%)
marketing                               -348 B  (-0.0%)    +2480 B  (+1.2%)
update-design-flow                      +224 B  (+0.0%)     +167 B  (+0.0%)
write-flow                              +218 B  (+0.0%)     +502 B  (+0.2%)
build-flow                              +218 B  (+0.0%)     +483 B  (+0.2%)
link-in-bio-tld-flow                    +215 B  (+0.0%)     +218 B  (+0.0%)
videopress-flow                         +125 B  (+0.0%)     +196 B  (+0.1%)
sensei-flow                             +123 B  (+0.0%)     +681 B  (+0.4%)
podcasts-flow                           +123 B  (+0.0%)     +658 B  (+0.4%)
copy-site-flow                          +123 B  (+0.0%)     +661 B  (+0.3%)
signup                                  +120 B  (+0.0%)      +14 B  (+0.0%)
with-theme-assembler-flow               +104 B  (+0.2%)       -4 B  (-0.0%)
update-options-flow                     +104 B  (+0.2%)       -1 B  (-0.0%)
trial-wooexpress-flow                   +104 B  (+0.2%)       +3 B  (+0.0%)
start-writing-flow                      +104 B  (+0.4%)      +21 B  (+0.3%)
site-setup-flow                         +104 B  (+0.2%)       -3 B  (-0.0%)
site-migration-flow                     +104 B  (+0.2%)       +2 B  (+0.0%)
migration-signup                        +104 B  (+0.2%)       +2 B  (+0.0%)
hosted-site-migration-flow              +104 B  (+0.2%)       +1 B  (+0.0%)
free-post-setup-flow                    +104 B  (+0.3%)       -2 B  (-0.0%)
free-flow                               +104 B  (+0.2%)       -5 B  (-0.1%)
entrepreneur-flow                       +104 B  (+0.2%)       +1 B  (+0.0%)
design-first-flow                       +104 B  (+0.4%)      +13 B  (+0.2%)
assembler-first-flow                    +104 B  (+0.1%)       -5 B  (-0.0%)
ai-assembler-flow                       +104 B  (+0.1%)       -1 B  (-0.0%)
devdocs                                  -73 B  (-0.0%)      -49 B  (-0.1%)
newsletter-flow                          +70 B  (+0.3%)      +21 B  (+0.3%)
link-in-bio-flow                         +70 B  (+0.3%)      +21 B  (+0.4%)
hundred-year-plan                        +70 B  (+0.2%)       +4 B  (+0.0%)
tailored-ecommerce-flow                  +35 B  (+0.3%)       +0 B
reblogging-flow                          +35 B  (+0.4%)       +3 B  (+0.1%)
reader                                   +35 B  (+0.0%)      +10 B  (+0.0%)
jetpack-cloud-agency-sites-v2            +30 B  (+0.0%)     +199 B  (+0.0%)
a8c-for-agencies-sites                   +30 B  (+0.0%)     +199 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~26412 bytes removed 📉 [gzipped])

name                                                         parsed_size           gzip_size
async-load-calypso-my-sites-current-site-notice                  +1201 B  (+2.2%)    +1198 B  (+6.7%)
async-load-calypso-components-web-preview-component              +1201 B  (+0.3%)     +660 B  (+0.5%)
async-load-calypso-post-editor-editor-media-modal                +1005 B  (+0.1%)     +457 B  (+0.1%)
async-load-calypso-reader-sidebar                                 -715 B  (-0.4%)     +595 B  (+1.0%)
async-load-masterbar-launchpad-navigator                          +188 B  (+0.3%)     +705 B  (+4.1%)
async-load-calypso-my-sites-stats-pages-subscribers               +188 B  (+0.2%)     +740 B  (+1.7%)
async-load-design-blocks                                          -166 B  (-0.0%)     -879 B  (-0.1%)
async-load-signup-steps-domains                                   +123 B  (+0.0%)     +642 B  (+0.4%)
async-load-design-playground                                      +123 B  (+0.0%)     +655 B  (+0.2%)
async-load-calypso-blocks-jitm-templates-sidebar-banner           +123 B  (+0.3%)     +776 B  (+5.5%)
async-load-calypso-blocks-jitm-templates-notice                   +123 B  (+0.3%)     +776 B  (+5.5%)
async-load-calypso-blocks-jitm-templates-default                  +123 B  (+0.3%)     +782 B  (+5.5%)
async-load-calypso-blocks-jitm                                    +105 B  (+1.0%)      +14 B  (+0.4%)
async-load-calypso-my-sites-sidebar                                +70 B  (+0.2%)      +17 B  (+0.2%)
async-load-calypso-my-sites-stats-stats-post-detail                +35 B  (+0.1%)       +7 B  (+0.1%)
async-load-calypso-my-sites-site-settings-seo-settings-form        +35 B  (+0.0%)       +6 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[DustyReagan]

Nice! Thanks for cleaning up this code!

[taipeicoder]

Thanks for the clean-up 🙂