Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Remove WPCOM upsells in Gravatar flow checkout thank-you page (alternative) #91069

Merged

Conversation

leonardost
Copy link
Contributor

@leonardost leonardost commented May 23, 2024

Related to #90414

Proposed Changes

Depends on D149807-code.

This PR removes the WPCOM specific upsells from the checkout thank-you page when a domain for Gravatar is bought. It also replaces the CTA buttons to only one that reads "Manage domain at Gravatar", which takes the user to https://gravatar.com/profile.

Screenshots

Before After
Screenshot 2024-05-22 at 20 31 38 Screenshot 2024-05-22 at 20 31 20

Why are these changes being made?

This is part of the Custom Domains on Gravatar project (pcYYhz-24z-p2).

Testing Instructions

  • Apply D149807-code to your sandbox
  • Open the live Calypso link or build this branch locally
  • Navigate to the thank you page for the receipt of a Gravatar domain purchase (e.g. /checkout/thank-you/no-site/93520523)
  • Ensure no WPCOM CTAs are shown
  • Open the thank-you page for any other domain-only purchase receipt and ensure the usual WPCOM CTAs are shown

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented May 23, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~31 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout       +103 B  (+0.0%)      +31 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~28 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     +62 B  (+0.0%)      +28 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       +62 B  (+0.0%)      +28 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +62 B  (+0.0%)      +28 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                              +62 B  (+0.0%)      +28 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                                         +62 B  (+0.0%)      +28 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@leonardost leonardost changed the title Hide WPCOM CTAs from DomainOnlyThankYou component if is_gravatar_domain prop is true Hide WPCOM CTAs from checkout Thank You page component if isGravatarDomain property is true May 23, 2024
@matticbot
Copy link
Contributor

matticbot commented May 23, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/prepare-thank-you-page-for-gravatar-domain-flow on your sandbox.

@leonardost leonardost self-assigned this May 23, 2024
@leonardost leonardost changed the title Hide WPCOM CTAs from checkout Thank You page component if isGravatarDomain property is true Domains: Hide WPCOM CTAs from checkout Thank You page component if isGravatarDomain property is true May 23, 2024
@leonardost leonardost marked this pull request as ready for review May 23, 2024 18:38
@leonardost leonardost requested a review from a team as a code owner May 23, 2024 18:59
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 23, 2024
@leonardost leonardost changed the title Domains: Hide WPCOM CTAs from checkout Thank You page component if isGravatarDomain property is true Domains: Remove WPCOM upsells in Gravatar flow checkout thank-you page (alternative) May 23, 2024
@leonardost leonardost force-pushed the update/prepare-thank-you-page-for-gravatar-domain-flow branch from 5883208 to 7522727 Compare May 29, 2024 19:23
@leonardost leonardost merged commit 38b6824 into trunk May 29, 2024
11 checks passed
@leonardost leonardost deleted the update/prepare-thank-you-page-for-gravatar-domain-flow branch May 29, 2024 22:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants